Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp

Issue 2653883006: [bindings] Move callback functions from V8FooInternal namespace to V8Foo class (Closed)
Patch Set: Revert expose change Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
index 1b04835f13efef845ad449d5c68242705753ae76..08a5c78c7751e8234074c33fde8438260fe80c1a 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
@@ -62,10 +62,6 @@ static void typeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info)
v8SetReturnValueString(info, impl->fastGetAttribute(SVGNames::typeAttr), info.GetIsolate());
}
-CORE_EXPORT void typeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
- SVGTestInterfaceV8Internal::typeAttributeGetter(info);
-}
-
static void typeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
SVGTestInterface* impl = V8SVGTestInterface::toImpl(holder);
@@ -81,7 +77,13 @@ static void typeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Function
impl->setAttribute(SVGNames::typeAttr, cppValue);
}
-CORE_EXPORT void typeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+} // namespace SVGTestInterfaceV8Internal
+
+void V8SVGTestInterface::typeAttributeGetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+ SVGTestInterfaceV8Internal::typeAttributeGetter(info);
+}
+
+void V8SVGTestInterface::typeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
v8::Local<v8::Value> v8Value = info[0];
V0CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;
@@ -89,10 +91,8 @@ CORE_EXPORT void typeAttributeSetterCallback(const v8::FunctionCallbackInfo<v8::
SVGTestInterfaceV8Internal::typeAttributeSetter(v8Value, info);
}
-} // namespace SVGTestInterfaceV8Internal
-
const V8DOMConfiguration::AccessorConfiguration V8SVGTestInterfaceAccessors[] = {
- {"type", SVGTestInterfaceV8Internal::typeAttributeGetterCallback, SVGTestInterfaceV8Internal::typeAttributeSetterCallback, 0, 0, nullptr, 0, static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
+ {"type", V8SVGTestInterface::typeAttributeGetterCallback, V8SVGTestInterface::typeAttributeSetterCallback, nullptr, nullptr, nullptr, nullptr, static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::OnPrototype, V8DOMConfiguration::CheckHolder},
};
static void installV8SVGTestInterfaceTemplate(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate) {

Powered by Google App Engine
This is Rietveld 408576698