Deprecate the currently used NGMarginStrut in favor of the new one.

Deprecate the currently used NGMarginStrut in favor of the new one.

This will deprecate NGMarginStrut and introduce the new NGMarginStrut with new interface.
See http://crrev.com/2597823004 for more details about how it will be used.

BUG=635619
Review-Url: https://codereview.chromium.org/2651853002
Cr-Commit-Position: refs/heads/master@{#445709}
Committed: https://chromium.googlesource.com/chromium/src/+/babdd037f833053d63076cdc01143d76977db23d

[Gleb Lanbin, 2017-01-23 23:47:05]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-01-24 00:06:34]

Patchset #2 (id:20001) has been deleted

[Gleb Lanbin, 2017-01-24 00:07:25]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 00:08:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-01-24 00:22:13]

lgtm

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_units.cc (right):

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_units.cc:275: LayoutUnit
NGMarginStrut::CollapseWith(const NGMarginStrut& other) const {
I don't think you'll need this, re: 0 block size conversation we had about the
other algorithm. fine with keeping at the moment, just add a mental note to
remove if needed. (or an actual note here :) )

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_units.h (right):

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_units.h:49: friend class
NGBlockLayoutAlgorithmTest;
can you ad a comment here as to why friend class?

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_units.h:100: friend class
NGBlockLayoutAlgorithmTest;
as above.

[commit-bot: I haz the power, 2017-01-24 02:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 02:53:30]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-01-24 04:38:02]

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_units.cc (right):

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_units.cc:275: LayoutUnit
NGMarginStrut::CollapseWith(const NGMarginStrut& other) const {
On 2017/01/24 00:22:13, ikilpatrick wrote:
> I don't think you'll need this, re: 0 block size conversation we had about the
> other algorithm. fine with keeping at the moment, just add a mental note to
> remove if needed. (or an actual note here :) )

deleted for now.

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_units.h (right):

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_units.h:49: friend class
NGBlockLayoutAlgorithmTest;
On 2017/01/24 00:22:13, ikilpatrick wrote:
> can you ad a comment here as to why friend class?

Done.

https://codereview.chromium.org/2651853002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_units.h:100: friend class
NGBlockLayoutAlgorithmTest;
On 2017/01/24 00:22:13, ikilpatrick wrote:
> as above.

Done.

[Gleb Lanbin, 2017-01-24 04:38:11]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 04:38:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 04:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 04:40:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Gleb Lanbin, 2017-01-24 05:32:54]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 05:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 05:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 05:45:46]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Gleb Lanbin, 2017-01-24 06:02:09]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 06:02:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 07:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 07:35:22]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-01-24 12:23:32]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-01-24 12:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2651853002/#ps100001
(title: "git rebase-update")

[commit-bot: I haz the power, 2017-01-24 12:23:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 12:27:43]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485260612494630,
"parent_rev": "e0a6fba88e2bf737191e3124331d359d89730157", "commit_rev":
"babdd037f833053d63076cdc01143d76977db23d"}

[commit-bot: I haz the power, 2017-01-24 12:28:15]

Description was changed from

==========
Deprecate the currently used NGMarginStrut in favor of the new one.

This will deprecate NGMarginStrut and introduce the new NGMarginStrut with new
interface.
See http://crrev.com/2597823004 for more details about how it will be used.

BUG=635619
==========

to

==========
Deprecate the currently used NGMarginStrut in favor of the new one.

This will deprecate NGMarginStrut and introduce the new NGMarginStrut with new
interface.
See http://crrev.com/2597823004 for more details about how it will be used.

BUG=635619

Review-Url: https://codereview.chromium.org/2651853002
Cr-Commit-Position: refs/heads/master@{#445709}
Committed:
https://chromium.googlesource.com/chromium/src/+/babdd037f833053d63076cdc0114...
==========

[commit-bot: I haz the power, 2017-01-24 12:28:17]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/babdd037f833053d63076cdc0114...