third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc - Issue 2651853002: Deprecate the currently used NGMarginStrut in favor of the new one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

Issue 2651853002: Deprecate the currently used NGMarginStrut in favor of the new one. (Closed)

Patch Set: git rebase-update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc b/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

index 40d77d47304912c031e3a123903a1011dfaab840..cda163878d7a046513c72502aa33c946e166e3e8 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

@@ -9,7 +9,7 @@

namespace blink {

-NGMarginStrut NGBoxFragment::MarginStrut() const {

+NGDeprecatedMarginStrut NGBoxFragment::MarginStrut() const {

WRITING_MODE_IGNORED(

"Accessing the margin strut is fine here. Changing the writing mode"

"establishes a new formatting context, for which a margin strut is never"