third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc - Issue 2651853002: Deprecate the currently used NGMarginStrut in favor of the new one.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_box_fragment.cc

Issue 2651853002: Deprecate the currently used NGMarginStrut in favor of the new one. (Closed)

Patch Set: git rebase-update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/layout/ng/ng_box_fragment.h"	5 #include "core/layout/ng/ng_box_fragment.h"

6	6

7 #include "core/layout/ng/ng_macros.h"	7 #include "core/layout/ng/ng_macros.h"

8 #include "core/layout/ng/ng_physical_box_fragment.h"	8 #include "core/layout/ng/ng_physical_box_fragment.h"

9	9

10 namespace blink {	10 namespace blink {

11	11

12 NGMarginStrut NGBoxFragment::MarginStrut() const {	12 NGDeprecatedMarginStrut NGBoxFragment::MarginStrut() const {

13 WRITING_MODE_IGNORED(	13 WRITING_MODE_IGNORED(

14 "Accessing the margin strut is fine here. Changing the writing mode"	14 "Accessing the margin strut is fine here. Changing the writing mode"

15 "establishes a new formatting context, for which a margin strut is never"	15 "establishes a new formatting context, for which a margin strut is never"

16 "set for a fragment.");	16 "set for a fragment.");

17 return toNGPhysicalBoxFragment(physical_fragment_)->MarginStrut();	17 return toNGPhysicalBoxFragment(physical_fragment_)->MarginStrut();

18 }	18 }

19	19

20 } // namespace blink	20 } // namespace blink

OLD	NEW