third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h - Issue 2651853002: Deprecate the currently used NGMarginStrut in favor of the new one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

Issue 2651853002: Deprecate the currently used NGMarginStrut in favor of the new one. (Closed)

Patch Set: git rebase-update Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

index 2821cdf8fd42c01c3411260cd1f6115537bd23e4..0a9edc26e9eece2dd60a423fa013742e7c330612 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

@@ -24,7 +24,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {

HeapVector<Member<const NGPhysicalFragment>>& children,

HeapLinkedHashSet<WeakMember<NGBlockNode>>& out_of_flow_descendants,

Vector<NGStaticPosition>& out_of_flow_positions,

- NGMarginStrut margin_strut,

+ NGDeprecatedMarginStrut margin_strut,

HeapVector<Member<NGFloatingObject>>& unpositioned_floats,

HeapVector<Member<NGFloatingObject>>& positioned_floats,

NGBreakToken* break_token = nullptr);

@@ -33,13 +33,13 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {

return children_;

}

- NGMarginStrut MarginStrut() const { return margin_strut_; }

+ NGDeprecatedMarginStrut MarginStrut() const { return margin_strut_; }

DECLARE_TRACE_AFTER_DISPATCH();

private:

HeapVector<Member<const NGPhysicalFragment>> children_;

- NGMarginStrut margin_strut_;

+ NGDeprecatedMarginStrut margin_strut_;

};

WILL_NOT_BE_EAGERLY_TRACED_CLASS(NGPhysicalBoxFragment);