[LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method.

[LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method.

Algorithms now just call the Layout() method on the NGInputNode which is
responsible for selecting an algorithm to produce a fragment.

BUG=635619
Review-Url: https://codereview.chromium.org/2649583002
Cr-Commit-Position: refs/heads/master@{#445292}
Committed: https://chromium.googlesource.com/chromium/src/+/0df262f32f773d7655aba8b5990ffbc2d04cc622

[ikilpatrick, 2017-01-20 18:03:06]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 18:03:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-01-20 18:06:34]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:34:13]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2017-01-20 21:21:56]

lgtm thanks!

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(left):

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:299:
current_child_->UpdateLayoutBox(toNGPhysicalBoxFragment(child_fragment),
Oh I see... this was only needed because we did not call box::Layout... wow,
glad we got rid of that.

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:97:
NGPhysicalFragment* physical_fragment = this->Layout(constraint_space);
Why the "this->"?

[ikilpatrick, 2017-01-20 23:19:57]

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(left):

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:299:
current_child_->UpdateLayoutBox(toNGPhysicalBoxFragment(child_fragment),
On 2017/01/20 21:21:56, cbiesinger wrote:
> Oh I see... this was only needed because we did not call box::Layout... wow,
> glad we got rid of that.

Yeah going through the boxes now might make things easier.

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right):

https://codereview.chromium.org/2649583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:97:
NGPhysicalFragment* physical_fragment = this->Layout(constraint_space);
On 2017/01/20 21:21:56, cbiesinger wrote:
> Why the "this->"?

Because I am a doofus :), done.

[ikilpatrick, 2017-01-20 23:20:16]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-01-20 23:20:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2649583002/#ps40001
(title: "address comments.")

[commit-bot: I haz the power, 2017-01-20 23:20:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 02:09:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 02:09:45]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:329
  error: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:
patch does not apply

Patch:      
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
diff --git
a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
index
238c3b0dc9b0e67b3b35ff7d137341c747ca0ecb..045d35587316e7401d7946b5f2af492f3e2d92ba
100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
@@ -219,10 +219,7 @@ bool NGBlockLayoutAlgorithm::ComputeMinAndMaxContentSizes(
   return true;
 }
 
-NGLayoutStatus NGBlockLayoutAlgorithm::Layout(
-    NGPhysicalFragment* child_fragment,
-    NGPhysicalFragment** fragment_out,
-    NGLayoutAlgorithm** algorithm_out) {
+NGPhysicalFragment* NGBlockLayoutAlgorithm::Layout() {
   WTF::Optional<MinAndMaxContentSizes> sizes;
   if (NeedMinAndMaxContentSizes(ConstraintSpace(), Style())) {
     // TODO(ikilpatrick): Change ComputeMinAndMaxContentSizes to return
@@ -291,13 +288,8 @@ NGLayoutStatus NGBlockLayoutAlgorithm::Layout(
            SpaceAvailableForCurrentChild() > LayoutUnit());
     space_for_current_child_ = CreateConstraintSpaceForCurrentChild();
 
-    NGFragment* fragment;
-    current_child_->LayoutSync(space_for_current_child_, &fragment);
-    NGPhysicalFragment* child_fragment = fragment->PhysicalFragment();
-
-    // TODO(layout_ng): Seems like a giant hack to call this here.
-    current_child_->UpdateLayoutBox(toNGPhysicalBoxFragment(child_fragment),
-                                    space_for_current_child_);
+    NGPhysicalFragment* child_fragment =
+        current_child_->Layout(space_for_current_child_);
 
     FinishCurrentChildLayout(new NGBoxFragment(
         ConstraintSpace().WritingMode(), ConstraintSpace().Direction(),
@@ -329,8 +321,7 @@ NGLayoutStatus NGBlockLayoutAlgorithm::Layout(
   if (ConstraintSpace().HasBlockFragmentation())
     FinalizeForFragmentation();
 
-  *fragment_out = builder_->ToBoxFragment();
-  return kNewFragment;
+  return builder_->ToBoxFragment();
 }
 
 void NGBlockLayoutAlgorithm::FinishCurrentChildLayout(NGFragment* fragment) {

[ikilpatrick, 2017-01-21 05:40:18]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-01-21 05:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2649583002/#ps60001
(title: "rebase.")

[commit-bot: I haz the power, 2017-01-21 05:40:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 07:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 07:18:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ikilpatrick, 2017-01-21 17:58:54]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2017-01-21 17:58:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2649583002/#ps80001
(title: "rebase v2")

[commit-bot: I haz the power, 2017-01-21 17:59:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 20:04:50]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485021534904350,
"parent_rev": "ac3b36a8e91405bedccaa90e221b784c26cbadb5", "commit_rev":
"0df262f32f773d7655aba8b5990ffbc2d04cc622"}

[commit-bot: I haz the power, 2017-01-21 20:05:24]

Description was changed from

==========
[LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method.

Algorithms now just call the Layout() method on the NGInputNode which is
responsible for selecting an algorithm to produce a fragment.

BUG=635619
==========

to

==========
[LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method.

Algorithms now just call the Layout() method on the NGInputNode which is
responsible for selecting an algorithm to produce a fragment.

BUG=635619

Review-Url: https://codereview.chromium.org/2649583002
Cr-Commit-Position: refs/heads/master@{#445292}
Committed:
https://chromium.googlesource.com/chromium/src/+/0df262f32f773d7655aba8b5990f...
==========

[commit-bot: I haz the power, 2017-01-21 20:05:25]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0df262f32f773d7655aba8b5990f...