Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

Issue 2649583002: [LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method. (Closed)
Patch Set: rebase v2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h
index d7bb052061ec79188c34a15bfbfa9ede56e8a3ff..67b696e0c3c599229f7e46a077ccc00409fe169f 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h
@@ -17,9 +17,8 @@ class LayoutBox;
class LayoutObject;
class NGBreakToken;
class NGConstraintSpace;
-class NGFragment;
-class NGLayoutCoordinator;
struct NGLogicalOffset;
+class NGPhysicalFragment;
struct MinAndMaxContentSizes;
// Represents a node to be laid out.
@@ -34,8 +33,7 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {
~NGBlockNode() override;
- bool Layout(NGConstraintSpace*, NGFragment**) override;
- void LayoutSync(NGConstraintSpace*, NGFragment**);
+ NGPhysicalFragment* Layout(NGConstraintSpace* constraint_space) override;
NGBlockNode* NextSibling() override;
@@ -78,8 +76,6 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {
// Save static position for legacy AbsPos layout.
void SaveStaticOffsetForLegacy(const NGLogicalOffset&);
- void UpdateLayoutBox(NGPhysicalBoxFragment* fragment,
- const NGConstraintSpace* constraint_space);
// This is necessary for interop between old and new trees -- after our parent
// positions us, it calls this function so we can store the position on the
// underlying LayoutBox.
@@ -99,7 +95,6 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {
RefPtr<ComputedStyle> style_;
Member<NGBlockNode> next_sibling_;
Member<NGLayoutInputNode> first_child_;
- Member<NGLayoutCoordinator> layout_coordinator_;
// TODO(mstensho): An input node may produce multiple fragments, so this
// should probably be renamed to last_fragment_ or something like that, since
// the last fragment is all we care about when resuming layout.

Powered by Google App Engine
This is Rietveld 408576698