Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

Issue 2649583002: [LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method. (Closed)
Patch Set: rebase v2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
index f6950ee5e8ad051d66ab09840b776efd166bc922..cb2e90637d8304842522e37722d97e4acedd59b7 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
@@ -6,6 +6,7 @@
#include "core/layout/ng/ng_absolute_utils.h"
#include "core/layout/ng/ng_block_node.h"
+#include "core/layout/ng/ng_box_fragment.h"
#include "core/layout/ng/ng_constraint_space_builder.h"
#include "core/layout/ng/ng_fragment.h"
#include "core/layout/ng/ng_length_utils.h"
@@ -116,9 +117,12 @@ NGFragment* NGOutOfFlowLayoutPart::GenerateFragment(
builder.SetIsNewFormattingContext(true);
NGConstraintSpace* space = builder.ToConstraintSpace();
- NGFragment* fragment;
- node.LayoutSync(space, &fragment);
- return fragment;
+ NGPhysicalFragment* fragment = node.Layout(space);
+
+ // TODO(ikilpatrick): the writing mode switching here looks wrong.
+ return new NGBoxFragment(parent_space_->WritingMode(),
+ parent_space_->Direction(),
+ toNGPhysicalBoxFragment(fragment));
}
DEFINE_TRACE(NGOutOfFlowLayoutPart) {

Powered by Google App Engine
This is Rietveld 408576698