Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h

Issue 2649583002: [LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method. (Closed)
Patch Set: rebase v2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
index 510d833fdd73734fa1ee32305289c1f2ffe01f03..3c83e0858f6f5471b60f8f2b92f532d55a65387f 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h
@@ -13,7 +13,6 @@
namespace blink {
struct MinAndMaxContentSizes;
-class NGBlockNode;
class NGConstraintSpace;
class NGPhysicalFragment;
@@ -38,16 +37,8 @@ class CORE_EXPORT NGLayoutAlgorithm
// Actual layout function. Lays out the children and descendents within the
// constraints given by the NGConstraintSpace. Returns a fragment with the
// resulting layout information.
- // This function can not be const because for interruptible layout, we have
- // to be able to store state information.
- // If this function returns NotFinished, it has to be called again.
- // If it returns ChildAlgorithmRequired, the NGBlockNode out parameter will
- // be set with the NGBlockNode that needs to be layed out next.
- // If it returns NewFragment, the NGPhysicalFragmentBase out parameter
- // will contain the new fragment.
- virtual NGLayoutStatus Layout(NGPhysicalFragment*,
- NGPhysicalFragment**,
- NGLayoutAlgorithm**) = 0;
+ // TODO(layout-dev): attempt to make this function const.
+ virtual NGPhysicalFragment* Layout() = 0;
enum MinAndMaxState { kSuccess, kPending, kNotImplemented };

Powered by Google App Engine
This is Rietveld 408576698