Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc

Issue 2649583002: [LayoutNG] Remove the ng_layout_coordinator and temporary LayoutSync method. (Closed)
Patch Set: rebase v2 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc b/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
index 885c92a0809ca1b5d61fc663af4ba7ab73d8365e..8c861117e373bc0ec8cb1d59729d3200dba423e8 100644
--- a/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
+++ b/third_party/WebKit/Source/core/layout/ng/layout_ng_block_flow.cc
@@ -27,9 +27,7 @@ void LayoutNGBlockFlow::layoutBlock(bool relayoutChildren) {
// passes (probably FirstChild(), etc).
m_box = new NGBlockNode(this);
- NGFragment* fragment;
- while (!m_box->Layout(constraint_space, &fragment))
- ;
+ NGPhysicalFragment* fragment = m_box->Layout(constraint_space);
if (isOutOfFlowPositioned()) {
// In legacy layout, abspos differs from regular blocks in that abspos
@@ -46,7 +44,7 @@ void LayoutNGBlockFlow::layoutBlock(bool relayoutChildren) {
setLogicalTop(computedValues.m_position);
}
- for (auto& descendant : fragment->PhysicalFragment()->OutOfFlowDescendants())
+ for (auto& descendant : fragment->OutOfFlowDescendants())
descendant->UseOldOutOfFlowPositioning();
clearNeedsLayout();
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/BUILD.gn ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698