Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope

Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope

ExecutionContextTask is being deprecated. This CL replaces ExecutionContextTask
use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with
WTF::CrossThreadClosure.

BUG=625927
Review-Url: https://codereview.chromium.org/2645613006
Cr-Commit-Position: refs/heads/master@{#444751}
Committed: https://chromium.googlesource.com/chromium/src/+/7f3cc31c4c860e5cad96ad142562cd714c0fcf47

[nhiroki, 2017-01-19 08:40:43]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 08:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 09:47:10]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 09:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 09:50:03]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-01-19 09:51:18]

Description was changed from

==========
Worker: Stop using ExecutionContextTask on
WorkerLoaderProxy::postTaskToWorkerGlobalScope

BUG=625927
==========

to

==========
Worker: Stop using ExecutionContextTask on
WorkerLoaderProxy::postTaskToWorkerGlobalScope

ExecutionContextTask is being deprecated. This CL stops replaces
ExecutionContextTask use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with
WTF::CrossThreadClosure.

BUG=625927
==========

[nhiroki, 2017-01-19 09:51:48]

Description was changed from

==========
Worker: Stop using ExecutionContextTask on
WorkerLoaderProxy::postTaskToWorkerGlobalScope

ExecutionContextTask is being deprecated. This CL stops replaces
ExecutionContextTask use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with
WTF::CrossThreadClosure.

BUG=625927
==========

to

==========
Worker: Stop using ExecutionContextTask on
WorkerLoaderProxy::postTaskToWorkerGlobalScope

ExecutionContextTask is being deprecated. This CL replaces ExecutionContextTask
use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with
WTF::CrossThreadClosure.

BUG=625927
==========

[nhiroki, 2017-01-19 09:51:57]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2017-01-19 09:53:58]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org, tzik@chromium.org, yhirano@chromium.org

[nhiroki, 2017-01-19 09:53:58]

Hi, can you review this?

+yhirano@ for loader/websocket components
+tzik@ and haraken@ for the overall changes

Thanks!

[commit-bot: I haz the power, 2017-01-19 10:14:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 10:14:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2017-01-19 10:34:37]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 10:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-19 10:54:29]

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp:32: #include
"wtf/Assertions.h"
+wtf/Functional.h

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp:46: #include
"platform/weborigin/SecurityPolicy.h"
+wtf/Functional.h

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h:34: #include
"core/dom/ExecutionContextTask.h"
Not needed?

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h:118:
std::unique_ptr<WTF::CrossThreadClosure>) = 0;
WTF:: not needed?

[haraken, 2017-01-19 11:04:52]

LGTM

[tzik, 2017-01-19 11:49:47]

lgtm

[commit-bot: I haz the power, 2017-01-19 11:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 11:54:54]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-01-19 13:04:19]

kinuko@chromium.org changed reviewers:
+ kinuko@chromium.org

[kinuko, 2017-01-19 13:04:20]

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h:113: // A
TaskForwarder forwards an ExecutionContextTask to the worker thread.
nit: Please update this comment as well

(and lgtm/2)

[nhiroki, 2017-01-19 14:02:34]

Thank you. Updated.

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp:32: #include
"wtf/Assertions.h"
On 2017/01/19 10:54:29, yhirano wrote:
> +wtf/Functional.h

Done.

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp:46: #include
"platform/weborigin/SecurityPolicy.h"
On 2017/01/19 10:54:29, yhirano wrote:
> +wtf/Functional.h

Done.

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h (right):

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h:34: #include
"core/dom/ExecutionContextTask.h"
On 2017/01/19 10:54:29, yhirano wrote:
> Not needed?

Done.

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h:113: // A
TaskForwarder forwards an ExecutionContextTask to the worker thread.
On 2017/01/19 13:04:20, kinuko wrote:
> nit: Please update this comment as well
> 
> (and lgtm/2)

Done.

https://codereview.chromium.org/2645613006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h:118:
std::unique_ptr<WTF::CrossThreadClosure>) = 0;
On 2017/01/19 10:54:29, yhirano wrote:
> WTF:: not needed?

Done.

[nhiroki, 2017-01-19 14:02:41]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 14:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-01-19 14:15:19]

lgtm

[nhiroki, 2017-01-19 14:46:24]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2017-01-19 14:46:30]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-01-19 14:46:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, kinuko@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2645613006/#ps80001
(title: "address review comments")

[commit-bot: I haz the power, 2017-01-19 14:46:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:10:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484837190485540,
"parent_rev": "17c4a6c7ae7563f44594e6fd509f78bcd3d42323", "commit_rev":
"7f3cc31c4c860e5cad96ad142562cd714c0fcf47"}

[commit-bot: I haz the power, 2017-01-19 16:10:31]

Description was changed from

==========
Worker: Stop using ExecutionContextTask on
WorkerLoaderProxy::postTaskToWorkerGlobalScope

ExecutionContextTask is being deprecated. This CL replaces ExecutionContextTask
use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with
WTF::CrossThreadClosure.

BUG=625927
==========

to

==========
Worker: Stop using ExecutionContextTask on
WorkerLoaderProxy::postTaskToWorkerGlobalScope

ExecutionContextTask is being deprecated. This CL replaces ExecutionContextTask
use on WorkerLoaderProxy::postTaskToWorkerGlobalScope with
WTF::CrossThreadClosure.

BUG=625927

Review-Url: https://codereview.chromium.org/2645613006
Cr-Commit-Position: refs/heads/master@{#444751}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f3cc31c4c860e5cad96ad142562...
==========

[commit-bot: I haz the power, 2017-01-19 16:10:32]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7f3cc31c4c860e5cad96ad142562...