Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

This is a part of the project to deprecate ExecutionContextTask.

InProcessWorkerMessaginProxy passes ExecutionContext to
InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to
deprecate ExecutionContextTask. The messaging proxy should pass it in a
different way.

After this CL, the messaging proxy passes a pointer to WorkerThread and the
object proxy accesses ExecutionContext via WorkerThread. Consequently,
ExecutionContext passed by ExecutionContextTask is no longer necessary.

BUG=625927
Review-Url: https://codereview.chromium.org/2639153004
Cr-Commit-Position: refs/heads/master@{#444729}
Committed: https://chromium.googlesource.com/chromium/src/+/d377f2d2230bc9302eca1f725e919b3b6a4305f1

[nhiroki, 2017-01-19 09:21:54]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 09:22:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 09:31:28]

Description was changed from

==========
Worker: Stop accessing ExecutionContext via ExecutionContextTask

BUG=
==========

to

==========
Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

This is a part of the project to deprecate ExecutionContextTask.

InProcessWorkerMessaginProxy passes ExecutionContext to
InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to
deprecate ExecutionContextTask. The messaging proxy should pass it in a
different way.

After this CL, the messaging proxy passes a pointer to WorkerThread and the
object proxy accesses ExecutionContext via WorkerThread. Consequently,
ExecutionContext passed by ExecutionContextTask is no longer necessary.

BUG=625927
==========

[nhiroki, 2017-01-19 09:33:36]

Description was changed from

==========
Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

This is a part of the project to deprecate ExecutionContextTask.

InProcessWorkerMessaginProxy passes ExecutionContext to
InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to
deprecate ExecutionContextTask. The messaging proxy should pass it in a
different way.

After this CL, the messaging proxy passes a pointer to WorkerThread and the
object proxy accesses ExecutionContext via WorkerThread. Consequently,
ExecutionContext passed by ExecutionContextTask is no longer necessary.

BUG=625927
==========

to

==========
Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

This is a part of the project to deprecate ExecutionContextTask.

InProcessWorkerMessaginProxy passes ExecutionContext to
InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to
deprecate ExecutionContextTask. The messaging proxy should pass it in a
different way.

After this CL, the messaging proxy passes a pointer to WorkerThread and the
object proxy accesses ExecutionContext via WorkerThread. Consequently,
ExecutionContext passed by ExecutionContextTask is no longer necessary.

BUG=625927
==========

[nhiroki, 2017-01-19 09:33:36]

nhiroki@chromium.org changed reviewers:
+ tzik@chromium.org

[nhiroki, 2017-01-19 09:33:45]

PTAL, thanks!

[commit-bot: I haz the power, 2017-01-19 10:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 10:02:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-01-19 10:05:52]

https://codereview.chromium.org/2639153004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
(right):

https://codereview.chromium.org/2639153004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp:143:
WTF::passed(std::move(channels)), crossThreadUnretained(workerThread()));
Hmmm... this workerThread() can be nullptr and then crashes. I'll fix this.

[nhiroki, 2017-01-19 10:24:36]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 10:24:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 10:37:23]

https://codereview.chromium.org/2639153004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
(right):

https://codereview.chromium.org/2639153004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp:143:
WTF::passed(std::move(channels)), crossThreadUnretained(workerThread()));
On 2017/01/19 10:05:52, nhiroki wrote:
> Hmmm... this workerThread() can be nullptr and then crashes. I'll fix this.

OK. This is fixed.

[tzik, 2017-01-19 11:41:03]

lgtm

https://codereview.chromium.org/2639153004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
(right):

https://codereview.chromium.org/2639153004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h:105:
QueuedTask(PassRefPtr<SerializedScriptValue> message,
Can we use RefPtr instead of PassRefPtr?

[commit-bot: I haz the power, 2017-01-19 11:50:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 11:50:18]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-01-19 12:34:40]

Thank you.

https://codereview.chromium.org/2639153004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
(right):

https://codereview.chromium.org/2639153004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h:105:
QueuedTask(PassRefPtr<SerializedScriptValue> message,
On 2017/01/19 11:41:03, tzik wrote:
> Can we use RefPtr instead of PassRefPtr?

Done.

[nhiroki, 2017-01-19 12:34:56]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-01-19 12:34:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/2639153004/#ps40001
(title: "address review comments")

[commit-bot: I haz the power, 2017-01-19 12:35:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 14:41:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484829296848730,
"parent_rev": "e31ad3babf2b92adee775cd55b7946e56d4d7979", "commit_rev":
"d377f2d2230bc9302eca1f725e919b3b6a4305f1"}

[commit-bot: I haz the power, 2017-01-19 14:41:44]

Description was changed from

==========
Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

This is a part of the project to deprecate ExecutionContextTask.

InProcessWorkerMessaginProxy passes ExecutionContext to
InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to
deprecate ExecutionContextTask. The messaging proxy should pass it in a
different way.

After this CL, the messaging proxy passes a pointer to WorkerThread and the
object proxy accesses ExecutionContext via WorkerThread. Consequently,
ExecutionContext passed by ExecutionContextTask is no longer necessary.

BUG=625927
==========

to

==========
Worker: Stop accessing ExecutionContext passed by ExecutionContextTask

This is a part of the project to deprecate ExecutionContextTask.

InProcessWorkerMessaginProxy passes ExecutionContext to
InProcessWorkerObjectProxy via ExecutionContextTask. This is a barrier to
deprecate ExecutionContextTask. The messaging proxy should pass it in a
different way.

After this CL, the messaging proxy passes a pointer to WorkerThread and the
object proxy accesses ExecutionContext via WorkerThread. Consequently,
ExecutionContext passed by ExecutionContextTask is no longer necessary.

BUG=625927

Review-Url: https://codereview.chromium.org/2639153004
Cr-Commit-Position: refs/heads/master@{#444729}
Committed:
https://chromium.googlesource.com/chromium/src/+/d377f2d2230bc9302eca1f725e91...
==========

[commit-bot: I haz the power, 2017-01-19 14:41:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d377f2d2230bc9302eca1f725e91...