third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp - Issue 2645613006: Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

Issue 2645613006: Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope (Closed)

Patch Set: address review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

index e70ec8f2418dffd3ffbcf01396be1fd430b18f44..c0be1a3bc7cd1a75d51cdc835be6f7f555479d32 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp

@@ -60,10 +60,10 @@ void ThreadedWorkletMessagingProxy::evaluateScript(

const ScriptSourceCode& scriptSourceCode) {

postTaskToWorkerGlobalScope(

BLINK_FROM_HERE,

- createCrossThreadTask(&ThreadedWorkletObjectProxy::evaluateScript,

- crossThreadUnretained(m_workletObjectProxy.get()),

- scriptSourceCode.source(), scriptSourceCode.url(),

- crossThreadUnretained(workerThread())));

+ crossThreadBind(&ThreadedWorkletObjectProxy::evaluateScript,

+ crossThreadUnretained(m_workletObjectProxy.get()),

+ scriptSourceCode.source(), scriptSourceCode.url(),

+ crossThreadUnretained(workerThread())));

}

void ThreadedWorkletMessagingProxy::terminateWorkletGlobalScope() {