Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

Issue 2645613006: Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope (Closed)
Patch Set: address review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
index 41ebccaa3a8dd68e55393821f0c2ac3b04f4ccdb..5a28dcdc36f39c946bcfd1f5b529e0b0221cc046 100644
--- a/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
+++ b/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
@@ -30,6 +30,7 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "wtf/Assertions.h"
+#include "wtf/Functional.h"
#include "wtf/PtrUtil.h"
#include "wtf/RefPtr.h"
#include <memory>
@@ -178,11 +179,11 @@ class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper,
WTF::makeUnique<WaitableEvent>();
postTaskToWorkerGlobalScope(
BLINK_FROM_HERE,
- createCrossThreadTask(
- &WorkerThreadableLoaderTestHelper::workerCreateLoader,
- crossThreadUnretained(this), crossThreadUnretained(client),
- crossThreadUnretained(completionEvent.get()),
- crossOriginRequestPolicy));
+ crossThreadBind(&WorkerThreadableLoaderTestHelper::workerCreateLoader,
+ crossThreadUnretained(this),
+ crossThreadUnretained(client),
+ crossThreadUnretained(completionEvent.get()),
+ crossOriginRequestPolicy));
completionEvent->wait();
}
@@ -191,10 +192,9 @@ class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper,
WTF::makeUnique<WaitableEvent>();
postTaskToWorkerGlobalScope(
BLINK_FROM_HERE,
- createCrossThreadTask(
- &WorkerThreadableLoaderTestHelper::workerStartLoader,
- crossThreadUnretained(this),
- crossThreadUnretained(completionEvent.get()), request));
+ crossThreadBind(&WorkerThreadableLoaderTestHelper::workerStartLoader,
+ crossThreadUnretained(this),
+ crossThreadUnretained(completionEvent.get()), request));
completionEvent->wait();
}
@@ -228,10 +228,9 @@ class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper,
WTF::makeUnique<WaitableEvent>();
postTaskToWorkerGlobalScope(
BLINK_FROM_HERE,
- createCrossThreadTask(
- &WorkerThreadableLoaderTestHelper::workerCallCheckpoint,
- crossThreadUnretained(this),
- crossThreadUnretained(completionEvent.get()), n));
+ crossThreadBind(&WorkerThreadableLoaderTestHelper::workerCallCheckpoint,
+ crossThreadUnretained(this),
+ crossThreadUnretained(completionEvent.get()), n));
completionEvent->wait();
}
@@ -254,12 +253,12 @@ class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper,
void onTearDown() override {
postTaskToWorkerGlobalScope(
BLINK_FROM_HERE,
- createCrossThreadTask(&WorkerThreadableLoaderTestHelper::clearLoader,
- crossThreadUnretained(this)));
+ crossThreadBind(&WorkerThreadableLoaderTestHelper::clearLoader,
+ crossThreadUnretained(this)));
WaitableEvent event;
postTaskToWorkerGlobalScope(
- BLINK_FROM_HERE, createCrossThreadTask(&WaitableEvent::signal,
- crossThreadUnretained(&event)));
+ BLINK_FROM_HERE,
+ crossThreadBind(&WaitableEvent::signal, crossThreadUnretained(&event)));
event.wait();
m_workerThread->terminateAndWait();
@@ -340,7 +339,7 @@ class WorkerThreadableLoaderTestHelper : public ThreadableLoaderTestHelper,
void postTaskToWorkerGlobalScope(
const WebTraceLocation& location,
- std::unique_ptr<ExecutionContextTask> task) override {
+ std::unique_ptr<WTF::CrossThreadClosure> task) override {
DCHECK(m_workerThread);
m_workerThread->postTask(location, std::move(task));
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698