Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp

Issue 2645613006: Worker: Stop using ExecutionContextTask on WorkerLoaderProxy::postTaskToWorkerGlobalScope (Closed)
Patch Set: address review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/loader/ThreadableLoader.h" 5 #include "core/loader/ThreadableLoader.h"
6 6
7 #include "core/dom/ExecutionContextTask.h" 7 #include "core/dom/ExecutionContextTask.h"
8 #include "core/fetch/MemoryCache.h" 8 #include "core/fetch/MemoryCache.h"
9 #include "core/fetch/ResourceLoaderOptions.h" 9 #include "core/fetch/ResourceLoaderOptions.h"
10 #include "core/loader/DocumentThreadableLoader.h" 10 #include "core/loader/DocumentThreadableLoader.h"
(...skipping 12 matching lines...) Expand all
23 #include "platform/testing/UnitTestHelpers.h" 23 #include "platform/testing/UnitTestHelpers.h"
24 #include "platform/weborigin/KURL.h" 24 #include "platform/weborigin/KURL.h"
25 #include "platform/weborigin/SecurityOrigin.h" 25 #include "platform/weborigin/SecurityOrigin.h"
26 #include "public/platform/Platform.h" 26 #include "public/platform/Platform.h"
27 #include "public/platform/WebURLLoadTiming.h" 27 #include "public/platform/WebURLLoadTiming.h"
28 #include "public/platform/WebURLLoaderMockFactory.h" 28 #include "public/platform/WebURLLoaderMockFactory.h"
29 #include "public/platform/WebURLResponse.h" 29 #include "public/platform/WebURLResponse.h"
30 #include "testing/gmock/include/gmock/gmock.h" 30 #include "testing/gmock/include/gmock/gmock.h"
31 #include "testing/gtest/include/gtest/gtest.h" 31 #include "testing/gtest/include/gtest/gtest.h"
32 #include "wtf/Assertions.h" 32 #include "wtf/Assertions.h"
33 #include "wtf/Functional.h"
33 #include "wtf/PtrUtil.h" 34 #include "wtf/PtrUtil.h"
34 #include "wtf/RefPtr.h" 35 #include "wtf/RefPtr.h"
35 #include <memory> 36 #include <memory>
36 37
37 namespace blink { 38 namespace blink {
38 39
39 namespace { 40 namespace {
40 41
41 using ::testing::_; 42 using ::testing::_;
42 using ::testing::InSequence; 43 using ::testing::InSequence;
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 WorkerThreadableLoaderTestHelper() 172 WorkerThreadableLoaderTestHelper()
172 : m_dummyPageHolder(DummyPageHolder::create(IntSize(1, 1))) {} 173 : m_dummyPageHolder(DummyPageHolder::create(IntSize(1, 1))) {}
173 174
174 void createLoader( 175 void createLoader(
175 ThreadableLoaderClient* client, 176 ThreadableLoaderClient* client,
176 CrossOriginRequestPolicy crossOriginRequestPolicy) override { 177 CrossOriginRequestPolicy crossOriginRequestPolicy) override {
177 std::unique_ptr<WaitableEvent> completionEvent = 178 std::unique_ptr<WaitableEvent> completionEvent =
178 WTF::makeUnique<WaitableEvent>(); 179 WTF::makeUnique<WaitableEvent>();
179 postTaskToWorkerGlobalScope( 180 postTaskToWorkerGlobalScope(
180 BLINK_FROM_HERE, 181 BLINK_FROM_HERE,
181 createCrossThreadTask( 182 crossThreadBind(&WorkerThreadableLoaderTestHelper::workerCreateLoader,
182 &WorkerThreadableLoaderTestHelper::workerCreateLoader, 183 crossThreadUnretained(this),
183 crossThreadUnretained(this), crossThreadUnretained(client), 184 crossThreadUnretained(client),
184 crossThreadUnretained(completionEvent.get()), 185 crossThreadUnretained(completionEvent.get()),
185 crossOriginRequestPolicy)); 186 crossOriginRequestPolicy));
186 completionEvent->wait(); 187 completionEvent->wait();
187 } 188 }
188 189
189 void startLoader(const ResourceRequest& request) override { 190 void startLoader(const ResourceRequest& request) override {
190 std::unique_ptr<WaitableEvent> completionEvent = 191 std::unique_ptr<WaitableEvent> completionEvent =
191 WTF::makeUnique<WaitableEvent>(); 192 WTF::makeUnique<WaitableEvent>();
192 postTaskToWorkerGlobalScope( 193 postTaskToWorkerGlobalScope(
193 BLINK_FROM_HERE, 194 BLINK_FROM_HERE,
194 createCrossThreadTask( 195 crossThreadBind(&WorkerThreadableLoaderTestHelper::workerStartLoader,
195 &WorkerThreadableLoaderTestHelper::workerStartLoader, 196 crossThreadUnretained(this),
196 crossThreadUnretained(this), 197 crossThreadUnretained(completionEvent.get()), request));
197 crossThreadUnretained(completionEvent.get()), request));
198 completionEvent->wait(); 198 completionEvent->wait();
199 } 199 }
200 200
201 // Must be called on the worker thread. 201 // Must be called on the worker thread.
202 void cancelLoader() override { 202 void cancelLoader() override {
203 DCHECK(m_workerThread); 203 DCHECK(m_workerThread);
204 DCHECK(m_workerThread->isCurrentThread()); 204 DCHECK(m_workerThread->isCurrentThread());
205 m_loader->cancel(); 205 m_loader->cancel();
206 } 206 }
207 207
(...skipping 13 matching lines...) Expand all
221 221
222 Checkpoint& checkpoint() override { return m_checkpoint; } 222 Checkpoint& checkpoint() override { return m_checkpoint; }
223 223
224 void callCheckpoint(int n) override { 224 void callCheckpoint(int n) override {
225 testing::runPendingTasks(); 225 testing::runPendingTasks();
226 226
227 std::unique_ptr<WaitableEvent> completionEvent = 227 std::unique_ptr<WaitableEvent> completionEvent =
228 WTF::makeUnique<WaitableEvent>(); 228 WTF::makeUnique<WaitableEvent>();
229 postTaskToWorkerGlobalScope( 229 postTaskToWorkerGlobalScope(
230 BLINK_FROM_HERE, 230 BLINK_FROM_HERE,
231 createCrossThreadTask( 231 crossThreadBind(&WorkerThreadableLoaderTestHelper::workerCallCheckpoint,
232 &WorkerThreadableLoaderTestHelper::workerCallCheckpoint, 232 crossThreadUnretained(this),
233 crossThreadUnretained(this), 233 crossThreadUnretained(completionEvent.get()), n));
234 crossThreadUnretained(completionEvent.get()), n));
235 completionEvent->wait(); 234 completionEvent->wait();
236 } 235 }
237 236
238 void onSetUp() override { 237 void onSetUp() override {
239 m_mockWorkerReportingProxy = WTF::makeUnique<MockWorkerReportingProxy>(); 238 m_mockWorkerReportingProxy = WTF::makeUnique<MockWorkerReportingProxy>();
240 m_securityOrigin = document().getSecurityOrigin(); 239 m_securityOrigin = document().getSecurityOrigin();
241 m_parentFrameTaskRunners = 240 m_parentFrameTaskRunners =
242 ParentFrameTaskRunners::create(&m_dummyPageHolder->frame()); 241 ParentFrameTaskRunners::create(&m_dummyPageHolder->frame());
243 m_workerThread = WTF::wrapUnique( 242 m_workerThread = WTF::wrapUnique(
244 new WorkerThreadForTest(this, *m_mockWorkerReportingProxy)); 243 new WorkerThreadForTest(this, *m_mockWorkerReportingProxy));
245 244
246 expectWorkerLifetimeReportingCalls(); 245 expectWorkerLifetimeReportingCalls();
247 m_workerThread->startWithSourceCode(m_securityOrigin.get(), 246 m_workerThread->startWithSourceCode(m_securityOrigin.get(),
248 "//fake source code"); 247 "//fake source code");
249 m_workerThread->waitForInit(); 248 m_workerThread->waitForInit();
250 } 249 }
251 250
252 void onServeRequests() override { testing::runPendingTasks(); } 251 void onServeRequests() override { testing::runPendingTasks(); }
253 252
254 void onTearDown() override { 253 void onTearDown() override {
255 postTaskToWorkerGlobalScope( 254 postTaskToWorkerGlobalScope(
256 BLINK_FROM_HERE, 255 BLINK_FROM_HERE,
257 createCrossThreadTask(&WorkerThreadableLoaderTestHelper::clearLoader, 256 crossThreadBind(&WorkerThreadableLoaderTestHelper::clearLoader,
258 crossThreadUnretained(this))); 257 crossThreadUnretained(this)));
259 WaitableEvent event; 258 WaitableEvent event;
260 postTaskToWorkerGlobalScope( 259 postTaskToWorkerGlobalScope(
261 BLINK_FROM_HERE, createCrossThreadTask(&WaitableEvent::signal, 260 BLINK_FROM_HERE,
262 crossThreadUnretained(&event))); 261 crossThreadBind(&WaitableEvent::signal, crossThreadUnretained(&event)));
263 event.wait(); 262 event.wait();
264 m_workerThread->terminateAndWait(); 263 m_workerThread->terminateAndWait();
265 264
266 // Needed to clean up the things on the main thread side and 265 // Needed to clean up the things on the main thread side and
267 // avoid Resource leaks. 266 // avoid Resource leaks.
268 testing::runPendingTasks(); 267 testing::runPendingTasks();
269 268
270 m_workerThread->workerLoaderProxy()->detachProvider(this); 269 m_workerThread->workerLoaderProxy()->detachProvider(this);
271 } 270 }
272 271
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 m_parentFrameTaskRunners->get(TaskType::Networking) 332 m_parentFrameTaskRunners->get(TaskType::Networking)
334 ->postTask( 333 ->postTask(
335 BLINK_FROM_HERE, 334 BLINK_FROM_HERE,
336 crossThreadBind(&ExecutionContextTask::performTaskIfContextIsValid, 335 crossThreadBind(&ExecutionContextTask::performTaskIfContextIsValid,
337 WTF::passed(std::move(task)), 336 WTF::passed(std::move(task)),
338 wrapCrossThreadWeakPersistent(&document()))); 337 wrapCrossThreadWeakPersistent(&document())));
339 } 338 }
340 339
341 void postTaskToWorkerGlobalScope( 340 void postTaskToWorkerGlobalScope(
342 const WebTraceLocation& location, 341 const WebTraceLocation& location,
343 std::unique_ptr<ExecutionContextTask> task) override { 342 std::unique_ptr<WTF::CrossThreadClosure> task) override {
344 DCHECK(m_workerThread); 343 DCHECK(m_workerThread);
345 m_workerThread->postTask(location, std::move(task)); 344 m_workerThread->postTask(location, std::move(task));
346 } 345 }
347 346
348 RefPtr<SecurityOrigin> m_securityOrigin; 347 RefPtr<SecurityOrigin> m_securityOrigin;
349 std::unique_ptr<MockWorkerReportingProxy> m_mockWorkerReportingProxy; 348 std::unique_ptr<MockWorkerReportingProxy> m_mockWorkerReportingProxy;
350 std::unique_ptr<WorkerThreadForTest> m_workerThread; 349 std::unique_ptr<WorkerThreadForTest> m_workerThread;
351 350
352 std::unique_ptr<DummyPageHolder> m_dummyPageHolder; 351 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
353 Persistent<ParentFrameTaskRunners> m_parentFrameTaskRunners; 352 Persistent<ParentFrameTaskRunners> m_parentFrameTaskRunners;
(...skipping 529 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 // test is not saying that didFailAccessControlCheck should be dispatched 882 // test is not saying that didFailAccessControlCheck should be dispatched
884 // synchronously, but is saying that even when a response is served 883 // synchronously, but is saying that even when a response is served
885 // synchronously it should not lead to a crash. 884 // synchronously it should not lead to a crash.
886 startLoader(KURL(KURL(), "about:blank")); 885 startLoader(KURL(KURL(), "about:blank"));
887 callCheckpoint(2); 886 callCheckpoint(2);
888 } 887 }
889 888
890 } // namespace 889 } // namespace
891 890
892 } // namespace blink 891 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698