Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Issue 2642113002: Worker: Reduce use of ExecutionContextTask in core/workers (Closed)

Created:
3 years, 11 months ago by nhiroki
Modified:
3 years, 11 months ago
Reviewers:
haraken, tzik
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Reduce use of ExecutionContextTask in core/workers ExecutionContextTask is deprecated in favor of WTF::Closure. BUG=625927 Review-Url: https://codereview.chromium.org/2642113002 Cr-Commit-Position: refs/heads/master@{#445028} Committed: https://chromium.googlesource.com/chromium/src/+/06f260832ead33668b4fa5a64074fb8a158b127f

Patch Set 1 #

Patch Set 2 : remove unnecessary header inclusion #

Patch Set 3 : include headers #

Patch Set 4 : fix build failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -54 lines) Patch
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 2 4 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
nhiroki
PTAL
3 years, 11 months ago (2017-01-19 23:17:27 UTC) #9
haraken
LGTM
3 years, 11 months ago (2017-01-20 01:01:38 UTC) #12
tzik
lgtm
3 years, 11 months ago (2017-01-20 01:57:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642113002/80001
3 years, 11 months ago (2017-01-20 03:41:23 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/367618)
3 years, 11 months ago (2017-01-20 05:05:18 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2642113002/100001
3 years, 11 months ago (2017-01-20 08:47:13 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:16:32 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/06f260832ead33668b4fa5a64074...

Powered by Google App Engine
This is Rietveld 408576698