Remove all blimp engine code

Remove all blimp engine code

This CL deletes the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556
Review-Url: https://codereview.chromium.org/2629743003
Cr-Commit-Position: refs/heads/master@{#443730}
Committed: https://chromium.googlesource.com/chromium/src/+/790e4f0610545c7e41ab4642e7856b058687e1e6

[nyquist, 2017-01-13 19:23:04]

nyquist@chromium.org changed reviewers:
+ dpranke@chromium.org, kmarshall@chromium.org, thakis@chromium.org

[nyquist, 2017-01-13 19:23:05]

dpranke: PTAL //PRESUBMIT.py and //build/args.
thakis: //tools/gritsettings/resource_ids and //chrome cleanup.
kmarshall: PTAL //blimp

[nyquist, 2017-01-13 19:24:51]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[Nico, 2017-01-13 19:25:37]

Description was changed from

==========
Delete blimp engine code

This CL deletees the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556
==========

to

==========
Delete blimp engine code

This CL deletes the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556
==========

[Dirk Pranke, 2017-01-13 19:25:42]

lgtm

[commit-bot: I haz the power, 2017-01-13 19:25:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-01-13 19:28:08]

lgtm

https://codereview.chromium.org/2629743003/diff/1/blimp/BUILD.gn
File blimp/BUILD.gn (right):

https://codereview.chromium.org/2629743003/diff/1/blimp/BUILD.gn#newcode22
blimp/BUILD.gn:22: group("blimp_tests") {
are we keeping these, or is this only here until bots stop running the tests?

https://codereview.chromium.org/2629743003/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/2629743003/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:109: //
//chrome/app/chrome_crash_reporter_client_win.cc::
nit: double // looks a bit strange

[Kevin M, 2017-01-13 19:28:23]

lgtm

[nyquist, 2017-01-13 19:39:44]

https://codereview.chromium.org/2629743003/diff/1/blimp/BUILD.gn
File blimp/BUILD.gn (right):

https://codereview.chromium.org/2629743003/diff/1/blimp/BUILD.gn#newcode22
blimp/BUILD.gn:22: group("blimp_tests") {
On 2017/01/13 19:28:07, Nico wrote:
> are we keeping these, or is this only here until bots stop running the tests?

No, they will all go. They are still running the tests in //blimp/net,
//blimp/common and //blimp/test/fake_engine, so when those things go, this also
goes.

I just didn't want one huge patch touching all kinds of weird places in the code
base at once, but instead removing one part at a time. Turns out there are a
bunch of arbitrary places that we mention blimp.

https://codereview.chromium.org/2629743003/diff/1/chrome/common/crash_keys.cc
File chrome/common/crash_keys.cc (right):

https://codereview.chromium.org/2629743003/diff/1/chrome/common/crash_keys.cc...
chrome/common/crash_keys.cc:109: //
//chrome/app/chrome_crash_reporter_client_win.cc::
On 2017/01/13 19:28:07, Nico wrote:
> nit: double // looks a bit strange

Done. Made more prettier.

[nyquist, 2017-01-13 19:40:18]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 19:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2017-01-13 21:54:18]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2017-01-13 21:54:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, thakis@chromium.org, kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2629743003/#ps60001
(title: "Use consistent comment style in //chrome")

[commit-bot: I haz the power, 2017-01-13 21:54:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2017-01-13 22:54:15]

Description was changed from

==========
Delete blimp engine code

This CL deletes the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556
==========

to

==========
Remove all blimp engine code

This CL deletes the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556
==========

[commit-bot: I haz the power, 2017-01-13 23:56:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484344458746020,
"parent_rev": "d7e86bf4d457fb8afd35871416afa706eb8856df", "commit_rev":
"790e4f0610545c7e41ab4642e7856b058687e1e6"}

[commit-bot: I haz the power, 2017-01-13 23:57:28]

Description was changed from

==========
Remove all blimp engine code

This CL deletes the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556
==========

to

==========
Remove all blimp engine code

This CL deletes the //blimp/engine directory and related files.

List of things that are updated:
- Build files.
- Top-level presubmit file regarding ScopedAllowIO access.
- Resource IDs for grit resources for both blimp engine and client.
- Comments in files that refer to //blimp/engine.
- The client_engine_integration.py script and build config.
- Default GN arguments for the blimp engine (file is kept empty).

Documentation is not updated yet.

BUG=677556

Review-Url: https://codereview.chromium.org/2629743003
Cr-Commit-Position: refs/heads/master@{#443730}
Committed:
https://chromium.googlesource.com/chromium/src/+/790e4f0610545c7e41ab4642e785...
==========

[commit-bot: I haz the power, 2017-01-13 23:57:29]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/790e4f0610545c7e41ab4642e785...