Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2629743003: Remove all blimp engine code (Closed)
Patch Set: Use consistent comment style in //chrome Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/args/blimp_engine.gn ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 int result = vsnprintf(buffer, size, format, arguments); 81 int result = vsnprintf(buffer, size, format, arguments);
82 va_end(arguments); 82 va_end(arguments);
83 return result; 83 return result;
84 } 84 }
85 85
86 size_t RegisterCrashKeysHelper() { 86 size_t RegisterCrashKeysHelper() {
87 // The following keys may be chunked by the underlying crash logging system, 87 // The following keys may be chunked by the underlying crash logging system,
88 // but ultimately constitute a single key-value pair. 88 // but ultimately constitute a single key-value pair.
89 // 89 //
90 // For now these need to be kept relatively up to date with those in 90 // For now these need to be kept relatively up to date with those in
91 // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys() and 91 // chrome/common/crash_keys.cc::RegisterChromeCrashKeys().
92 // //blimp/engine/app/blimp_engine_crash_keys.cc
93 constexpr base::debug::CrashKey fixed_keys[] = { 92 constexpr base::debug::CrashKey fixed_keys[] = {
94 {kMetricsClientId, kSmallSize}, 93 {kMetricsClientId, kSmallSize},
95 {kChannel, kSmallSize}, 94 {kChannel, kSmallSize},
96 {kActiveURL, kLargeSize}, 95 {kActiveURL, kLargeSize},
97 {kNumVariations, kSmallSize}, 96 {kNumVariations, kSmallSize},
98 {kVariations, kLargeSize}, 97 {kVariations, kLargeSize},
99 {kNumExtensionsCount, kSmallSize}, 98 {kNumExtensionsCount, kSmallSize},
100 {kShutdownType, kSmallSize}, 99 {kShutdownType, kSmallSize},
101 {kBrowserUnpinTrace, kMediumSize}, 100 {kBrowserUnpinTrace, kMediumSize},
102 {kGPUVendorID, kSmallSize}, 101 {kGPUVendorID, kSmallSize},
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 396 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
398 return install_static::GetCollectStatsInSample(); 397 return install_static::GetCollectStatsInSample();
399 } 398 }
400 399
401 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 400 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
402 const std::string& process_type) { 401 const std::string& process_type) {
403 // This is not used by Crashpad (at least on Windows). 402 // This is not used by Crashpad (at least on Windows).
404 NOTREACHED(); 403 NOTREACHED();
405 return true; 404 return true;
406 } 405 }
OLDNEW
« no previous file with comments | « build/args/blimp_engine.gn ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698