Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2632803002: Remove all blimp network code. (Closed)

Created:
3 years, 11 months ago by nyquist
Modified:
3 years, 11 months ago
CC:
anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, extensions-reviews_chromium.org, gcasto+watch-blimp_chromium.org, jshin+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all blimp network code. This CL deletes the //blimp/net directory. List of things that are updated: - Build files. - Comments in files that refer to //blimp/net. Documentation is not updated yet. TBR=rockot@chromium.org BUG=677556 Review-Url: https://codereview.chromium.org/2632803002 Cr-Commit-Position: refs/heads/master@{#444189} Committed: https://chromium.googlesource.com/chromium/src/+/3bbab9e965274605d4b83f7c5590d8806c6db835

Patch Set 1 #

Patch Set 2 : merge from origin/master for good measure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10222 lines) Patch
M blimp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M blimp/common/logging_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D blimp/net/BUILD.gn View 1 chunk +0 lines, -177 lines 0 comments Download
D blimp/net/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D blimp/net/blimp_connection.h View 1 chunk +0 lines, -61 lines 0 comments Download
D blimp/net/blimp_connection.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D blimp/net/blimp_engine_transport.h View 1 chunk +0 lines, -27 lines 0 comments Download
D blimp/net/blimp_message_checkpoint_observer.h View 1 chunk +0 lines, -24 lines 0 comments Download
D blimp/net/blimp_message_checkpointer.h View 1 chunk +0 lines, -62 lines 0 comments Download
D blimp/net/blimp_message_checkpointer.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D blimp/net/blimp_message_checkpointer_unittest.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D blimp/net/blimp_message_demultiplexer.h View 1 chunk +0 lines, -50 lines 0 comments Download
D blimp/net/blimp_message_demultiplexer.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/net/blimp_message_demultiplexer_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D blimp/net/blimp_message_multiplexer.h View 1 chunk +0 lines, -45 lines 0 comments Download
D blimp/net/blimp_message_multiplexer.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D blimp/net/blimp_message_multiplexer_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D blimp/net/blimp_message_output_buffer.h View 1 chunk +0 lines, -101 lines 0 comments Download
D blimp/net/blimp_message_output_buffer.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D blimp/net/blimp_message_output_buffer_unittest.cc View 1 chunk +0 lines, -263 lines 0 comments Download
D blimp/net/blimp_message_processor.h View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/net/blimp_message_pump.h View 1 chunk +0 lines, -76 lines 0 comments Download
D blimp/net/blimp_message_pump.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D blimp/net/blimp_message_pump_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D blimp/net/blimp_message_thread_pipe.h View 1 chunk +0 lines, -67 lines 0 comments Download
D blimp/net/blimp_message_thread_pipe.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D blimp/net/blimp_message_thread_pipe_unittest.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D blimp/net/blimp_net_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/net/blimp_stats.h View 1 chunk +0 lines, -59 lines 0 comments Download
D blimp/net/blimp_stats.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D blimp/net/blimp_stats_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D blimp/net/blimp_transport.h View 1 chunk +0 lines, -43 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_integration_test.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_receiver.h View 1 chunk +0 lines, -48 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_receiver.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_receiver_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_sender.h View 1 chunk +0 lines, -42 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_sender_impl.h View 1 chunk +0 lines, -63 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_sender_impl.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D blimp/net/blob_channel/blob_channel_sender_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D blimp/net/blob_channel/helium_blob_channel_unittest.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D blimp/net/blob_channel/helium_blob_receiver_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
D blimp/net/blob_channel/helium_blob_receiver_delegate.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D blimp/net/blob_channel/helium_blob_sender_delegate.h View 1 chunk +0 lines, -48 lines 0 comments Download
D blimp/net/blob_channel/helium_blob_sender_delegate.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D blimp/net/blob_channel/mock_blob_channel_receiver.h View 1 chunk +0 lines, -41 lines 0 comments Download
D blimp/net/blob_channel/mock_blob_channel_receiver.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D blimp/net/blob_channel/mock_blob_channel_sender.h View 1 chunk +0 lines, -31 lines 0 comments Download
D blimp/net/blob_channel/mock_blob_channel_sender.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D blimp/net/browser_connection_handler.h View 1 chunk +0 lines, -80 lines 0 comments Download
D blimp/net/browser_connection_handler.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D blimp/net/browser_connection_handler_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D blimp/net/client_connection_manager.h View 1 chunk +0 lines, -83 lines 0 comments Download
D blimp/net/client_connection_manager.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D blimp/net/client_connection_manager_unittest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D blimp/net/common.h View 1 chunk +0 lines, -21 lines 0 comments Download
D blimp/net/common.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D blimp/net/compressed_packet_reader.h View 1 chunk +0 lines, -67 lines 0 comments Download
D blimp/net/compressed_packet_reader.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D blimp/net/compressed_packet_unittest.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D blimp/net/compressed_packet_writer.h View 1 chunk +0 lines, -55 lines 0 comments Download
D blimp/net/compressed_packet_writer.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D blimp/net/connection_error_observer.h View 1 chunk +0 lines, -23 lines 0 comments Download
D blimp/net/connection_handler.h View 1 chunk +0 lines, -25 lines 0 comments Download
D blimp/net/delta_encoding.h View 1 chunk +0 lines, -124 lines 0 comments Download
D blimp/net/delta_encoding_unittest.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D blimp/net/engine_authentication_handler.h View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/net/engine_authentication_handler.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D blimp/net/engine_authentication_handler_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D blimp/net/engine_connection_manager.h View 1 chunk +0 lines, -60 lines 0 comments Download
D blimp/net/engine_connection_manager.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D blimp/net/engine_connection_manager_unittest.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D blimp/net/exact_match_cert_verifier.h View 1 chunk +0 lines, -47 lines 0 comments Download
D blimp/net/exact_match_cert_verifier.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/net/fake_blimp_message_processor.h View 1 chunk +0 lines, -36 lines 0 comments Download
D blimp/net/fake_blimp_message_processor.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D blimp/net/fake_pipe_manager.h View 1 chunk +0 lines, -46 lines 0 comments Download
D blimp/net/fake_pipe_manager.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D blimp/net/input_message_converter.h View 1 chunk +0 lines, -49 lines 0 comments Download
D blimp/net/input_message_converter.cc View 1 chunk +0 lines, -314 lines 0 comments Download
D blimp/net/input_message_generator.h View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/net/input_message_generator.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D blimp/net/input_message_unittest.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D blimp/net/message_port.h View 1 chunk +0 lines, -45 lines 0 comments Download
D blimp/net/message_port.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D blimp/net/null_blimp_message_processor.h View 1 chunk +0 lines, -27 lines 0 comments Download
D blimp/net/null_blimp_message_processor.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D blimp/net/packet_reader.h View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/net/packet_writer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/net/pipe_manager.h View 1 chunk +0 lines, -30 lines 0 comments Download
D blimp/net/ssl_client_transport.h View 1 chunk +0 lines, -65 lines 0 comments Download
D blimp/net/ssl_client_transport.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D blimp/net/ssl_client_transport_unittest.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D blimp/net/stream_packet_reader.h View 1 chunk +0 lines, -89 lines 0 comments Download
D blimp/net/stream_packet_reader.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D blimp/net/stream_packet_reader_unittest.cc View 1 chunk +0 lines, -433 lines 0 comments Download
D blimp/net/stream_packet_writer.h View 1 chunk +0 lines, -85 lines 0 comments Download
D blimp/net/stream_packet_writer.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D blimp/net/stream_packet_writer_unittest.cc View 1 chunk +0 lines, -304 lines 0 comments Download
D blimp/net/stream_socket_connection.h View 1 chunk +0 lines, -32 lines 0 comments Download
D blimp/net/stream_socket_connection.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D blimp/net/tcp_client_transport.h View 1 chunk +0 lines, -74 lines 0 comments Download
D blimp/net/tcp_client_transport.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D blimp/net/tcp_connection.h View 1 chunk +0 lines, -44 lines 0 comments Download
D blimp/net/tcp_connection.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D blimp/net/tcp_connection_unittest.cc View 1 chunk +0 lines, -225 lines 0 comments Download
D blimp/net/tcp_engine_transport.h View 1 chunk +0 lines, -59 lines 0 comments Download
D blimp/net/tcp_engine_transport.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D blimp/net/tcp_transport_unittest.cc View 1 chunk +0 lines, -135 lines 0 comments Download
D blimp/net/test_common.h View 1 chunk +0 lines, -230 lines 0 comments Download
D blimp/net/test_common.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D blimp/net/thread_pipe_manager.h View 1 chunk +0 lines, -63 lines 0 comments Download
D blimp/net/thread_pipe_manager.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D blimp/net/thread_pipe_manager_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M chrome/browser/extensions/api/socket/mock_tcp_client_socket.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
nyquist
kmarshall: PTAL
3 years, 11 months ago (2017-01-13 22:15:59 UTC) #2
Kevin M
lgtm
3 years, 11 months ago (2017-01-13 22:36:14 UTC) #5
nyquist
rockot: TBR chrome/browser/extensions/api/socket/mock_tcp_client_socket.h for deleting unnecessary comment.
3 years, 11 months ago (2017-01-13 22:42:43 UTC) #8
Ken Rockot(use gerrit already)
rs lgtm
3 years, 11 months ago (2017-01-17 22:02:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632803002/20001
3 years, 11 months ago (2017-01-17 22:24:27 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 23:43:56 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3bbab9e965274605d4b83f7c5590...

Powered by Google App Engine
This is Rietveld 408576698