Make FrameCaret contains CaretBase instead of deriving from it

Make FrameCaret to contain CaretBase

This patch makes |FrameCaret| to contain |CaretBase| rather than to be derived
it as similar as |DragCaretController| for improving code health.

This patch also makes |CaretBase| not to be a garbage collected object since
it doesn't hold garbage collected objects since [1].

This is a follow-up patch of [2] and suggested by [3].

[1] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[2] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[3] http://crrev.com/2635433003 Make DragCaretController to be derived from
CaretBase

BUG=680384
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2627423002
Cr-Commit-Position: refs/heads/master@{#443860}
Committed: https://chromium.googlesource.com/chromium/src/+/716fc5a4985347e1b2148b481278d0d37d2bb3d3

[yosin_UTC9, 2017-01-13 06:41:38]

Description was changed from

==========
2017-01-13T15:40:58

2017-01-13T15:40:49

BUG=
==========

to

==========
2017-01-13T15:40:58

2017-01-13T15:40:49

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[yosin_UTC9, 2017-01-13 06:44:56]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 06:45:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 06:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 06:55:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-01-13 07:10:43]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[yosin_UTC9, 2017-01-13 07:10:47]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-13 07:10:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 07:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 07:22:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2017-01-13 07:37:41]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 07:37:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 07:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 07:52:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2017-01-16 04:00:34]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[yosin_UTC9, 2017-01-16 04:00:43]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-01-16 04:00:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-16 04:00:51]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-16 04:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 04:11:37]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[yosin_UTC9, 2017-01-16 04:47:52]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 04:48:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 05:08:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 05:08:16]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[yosin_UTC9, 2017-01-16 05:24:26]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 05:24:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 07:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 07:07:30]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-16 07:56:26]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 07:56:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-16 08:25:33]

Description was changed from

==========
2017-01-13T15:40:58

2017-01-13T15:40:49

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make FrameCaret to contain CaretBase

This patch makes |FrameCaret| to contain |CaretBase| rather than to be derived
it as similar as |DragCaretController| for improving code health.

This is a follow-up patch of [1] and suggested by [2].

[1] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[2] http://crrev.com/2635433003 Make DragCaretController to be derived from
CaretBase

BUG=680384
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-16 08:25:34]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-01-16 08:28:11]

Description was changed from

==========
Make FrameCaret to contain CaretBase

This patch makes |FrameCaret| to contain |CaretBase| rather than to be derived
it as similar as |DragCaretController| for improving code health.

This is a follow-up patch of [1] and suggested by [2].

[1] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[2] http://crrev.com/2635433003 Make DragCaretController to be derived from
CaretBase

BUG=680384
TEST=n/a; no behavior changes
==========

to

==========
Make FrameCaret to contain CaretBase

This patch makes |FrameCaret| to contain |CaretBase| rather than to be derived
it as similar as |DragCaretController| for improving code health.

This patch also makes |CaretBase| not to be a garbage collected object since
it doesn't hold garbage collected objects since [1].

This is a follow-up patch of [2] and suggested by [3].

[1] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[2] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[3] http://crrev.com/2635433003 Make DragCaretController to be derived from
CaretBase

BUG=680384
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-01-16 08:28:17]

PTAL

[yoichio, 2017-01-16 08:52:04]

cool! lgtm.

[yosin_UTC9, 2017-01-16 08:56:59]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-01-16 08:57:01]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-01-16 08:57:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 09:22:21]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484557021790570,
"parent_rev": "cc6672f0ac58c0cd4439c647bbe096d84d4f2432", "commit_rev":
"716fc5a4985347e1b2148b481278d0d37d2bb3d3"}

[commit-bot: I haz the power, 2017-01-16 09:22:55]

Description was changed from

==========
Make FrameCaret to contain CaretBase

This patch makes |FrameCaret| to contain |CaretBase| rather than to be derived
it as similar as |DragCaretController| for improving code health.

This patch also makes |CaretBase| not to be a garbage collected object since
it doesn't hold garbage collected objects since [1].

This is a follow-up patch of [2] and suggested by [3].

[1] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[2] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[3] http://crrev.com/2635433003 Make DragCaretController to be derived from
CaretBase

BUG=680384
TEST=n/a; no behavior changes
==========

to

==========
Make FrameCaret to contain CaretBase

This patch makes |FrameCaret| to contain |CaretBase| rather than to be derived
it as similar as |DragCaretController| for improving code health.

This patch also makes |CaretBase| not to be a garbage collected object since
it doesn't hold garbage collected objects since [1].

This is a follow-up patch of [2] and suggested by [3].

[1] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[2] http://crrev.com/2623053006 Get rid of CaretBase::m_caretLocalRect
[3] http://crrev.com/2635433003 Make DragCaretController to be derived from
CaretBase

BUG=680384
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2627423002
Cr-Commit-Position: refs/heads/master@{#443860}
Committed:
https://chromium.googlesource.com/chromium/src/+/716fc5a4985347e1b2148b481278...
==========

[commit-bot: I haz the power, 2017-01-16 09:22:56]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/716fc5a4985347e1b2148b481278...