third_party/WebKit/Source/core/editing/DragCaretController.h - Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DragCaretController.h

Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it (Closed)

Patch Set: 2017-01-16T16:55:39 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DragCaretController.h

diff --git a/third_party/WebKit/Source/core/editing/DragCaretController.h b/third_party/WebKit/Source/core/editing/DragCaretController.h

index a001451c48f485763fe93e34215c70af738293b5..d02af83a80f95cfe58ea652a84b39cef306fc530 100644

--- a/third_party/WebKit/Source/core/editing/DragCaretController.h

+++ b/third_party/WebKit/Source/core/editing/DragCaretController.h

@@ -29,6 +29,7 @@

#include "core/dom/SynchronousMutationObserver.h"

#include "core/editing/CaretBase.h"

+#include <memory>

namespace blink {

@@ -66,7 +67,7 @@ class DragCaretController final

// caret rect in coords local to the layoutObject responsible for painting the

// caret

LayoutRect m_caretLocalRect;

- const Member<CaretBase> m_caretBase;

+ const std::unique_ptr<CaretBase> m_caretBase;

};

} // namespace blink