Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.cpp

Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it (Closed)
Patch Set: 2017-01-16T16:55:39 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CaretBase.cpp
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.cpp b/third_party/WebKit/Source/core/editing/CaretBase.cpp
index 57550300f094cdca408445d271ccc34031fcbd33..8b150d80bfd1ec86a976d7e250df4ae5b167a946 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.cpp
+++ b/third_party/WebKit/Source/core/editing/CaretBase.cpp
@@ -45,8 +45,6 @@ namespace blink {
CaretBase::CaretBase() = default;
CaretBase::~CaretBase() = default;
-DEFINE_TRACE(CaretBase) {}
-
static inline bool caretRendersInsideNode(Node* node) {
return node && !isDisplayInsideTable(node) && !editingIgnoresContent(*node);
}
@@ -120,7 +118,7 @@ LayoutRect CaretBase::computeCaretRect(const VisiblePosition& caretPosition) {
}
IntRect CaretBase::absoluteBoundsForLocalRect(Node* node,
- const LayoutRect& rect) const {
+ const LayoutRect& rect) {
LayoutBlock* caretPainter = caretLayoutObject(node);
if (!caretPainter)
return IntRect();
@@ -152,7 +150,7 @@ void CaretBase::invalidateLocalCaretRect(Node* node, const LayoutRect& rect) {
node->layoutObject()->invalidatePaintRectangle(inflatedRect, this);
}
-bool CaretBase::shouldRepaintCaret(Node& node) const {
+bool CaretBase::shouldRepaintCaret(Node& node) {
// If PositionAnchorType::BeforeAnchor or PositionAnchorType::AfterAnchor,
// carets need to be repainted not only when the node is contentEditable but
// also when its parentNode() is contentEditable.
« no previous file with comments | « third_party/WebKit/Source/core/editing/CaretBase.h ('k') | third_party/WebKit/Source/core/editing/DragCaretController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698