Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.h

Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it (Closed)
Patch Set: 2017-01-16T16:55:39 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/CaretBase.h
diff --git a/third_party/WebKit/Source/core/editing/CaretBase.h b/third_party/WebKit/Source/core/editing/CaretBase.h
index 264bc57b759250fb1efed304628229890ee7b6ff..c29b3f52f777dcfea8bc3274477667c2ec691990 100644
--- a/third_party/WebKit/Source/core/editing/CaretBase.h
+++ b/third_party/WebKit/Source/core/editing/CaretBase.h
@@ -27,7 +27,6 @@
#ifndef CaretBase_h
#define CaretBase_h
-#include "core/CoreExport.h"
#include "core/editing/VisiblePosition.h"
#include "platform/geometry/IntRect.h"
#include "platform/geometry/LayoutRect.h"
@@ -36,12 +35,10 @@
namespace blink {
-class DisplayItemClient;
class GraphicsContext;
class LayoutBlock;
-class CORE_EXPORT CaretBase : public GarbageCollectedFinalized<CaretBase>,
- public DisplayItemClient {
+class CaretBase final : public DisplayItemClient {
WTF_MAKE_NONCOPYABLE(CaretBase);
public:
@@ -60,11 +57,13 @@ class CORE_EXPORT CaretBase : public GarbageCollectedFinalized<CaretBase>,
// TODO(yosin): We should move |absoluteBoundsForLocalRect()| with
// |VisiblePosition| to "FrameCaret.cpp" as static file local function.
- IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&) const;
+ static IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&);
// TODO(yosin): We should move |shouldRepaintCaret()| to "FrameCaret.cpp" as
// static file local function.
- bool shouldRepaintCaret(Node&) const;
+ static bool shouldRepaintCaret(Node&);
+ // TODO(yosin): We should make |paintCaret()| to non-static member and get rid
+ // |DisplayItemClient| parameter.
static void paintCaret(Node*,
GraphicsContext&,
const DisplayItemClient&,
@@ -76,11 +75,9 @@ class CORE_EXPORT CaretBase : public GarbageCollectedFinalized<CaretBase>,
void invalidateLocalCaretRect(Node*, const LayoutRect&);
// DisplayItemClient methods.
- LayoutRect visualRect() const override;
+ LayoutRect visualRect() const final;
String debugName() const final;
- DECLARE_VIRTUAL_TRACE();
-
private:
LayoutRect m_visualRect;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698