Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it (Closed)
Patch Set: 2017-01-16T16:55:39 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameCaret.h
diff --git a/third_party/WebKit/Source/core/editing/FrameCaret.h b/third_party/WebKit/Source/core/editing/FrameCaret.h
index 6da45f284cc29f09678b52fe1475ebdfb809faa7..4679fa4e914af636060a4bbe6386ac4df2f9ff85 100644
--- a/third_party/WebKit/Source/core/editing/FrameCaret.h
+++ b/third_party/WebKit/Source/core/editing/FrameCaret.h
@@ -27,20 +27,33 @@
#define FrameCaret_h
#include "core/CoreExport.h"
-#include "core/editing/CaretBase.h"
-#include "platform/geometry/IntRect.h"
+#include "core/editing/PositionWithAffinity.h"
+#include "platform/Timer.h"
+#include "platform/geometry/LayoutRect.h"
+#include "platform/heap/GarbageCollected.h"
+#include "platform/heap/Member.h"
+#include <memory>
namespace blink {
+class CaretBase;
+class CharacterData;
+class DisplayItemClient;
+class Document;
+class GraphicsContext;
+class Node;
+class LocalFrame;
class SelectionEditor;
enum class CaretVisibility { Visible, Hidden };
-class CORE_EXPORT FrameCaret final : public CaretBase {
+class CORE_EXPORT FrameCaret final
+ : public GarbageCollectedFinalized<FrameCaret> {
public:
FrameCaret(LocalFrame&, const SelectionEditor&);
- ~FrameCaret() override;
+ ~FrameCaret();
+ const DisplayItemClient& displayItemClient() const;
bool isActive() const { return caretPosition().isNotNull(); }
void updateAppearance();
@@ -75,7 +88,7 @@ class CORE_EXPORT FrameCaret final : public CaretBase {
bool shouldPaintCaretForTesting() const { return m_shouldPaintCaret; }
bool isPreviousCaretDirtyForTesting() const { return m_previousCaretNode; }
- DECLARE_VIRTUAL_TRACE();
+ DECLARE_TRACE();
private:
friend class FrameSelectionTest;
@@ -88,6 +101,7 @@ class CORE_EXPORT FrameCaret final : public CaretBase {
const Member<const SelectionEditor> m_selectionEditor;
const Member<LocalFrame> m_frame;
+ const std::unique_ptr<CaretBase> m_caretBase;
// The last node which painted the caret. Retained for clearing the old
// caret when it moves.
Member<Node> m_previousCaretNode;
« no previous file with comments | « third_party/WebKit/Source/core/editing/DragCaretController.cpp ('k') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698