third_party/WebKit/Source/core/editing/DragCaretController.cpp - Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DragCaretController.cpp

Issue 2627423002: Make FrameCaret contains CaretBase instead of deriving from it (Closed)

Patch Set: 2017-01-16T16:55:39 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DragCaretController.cpp

diff --git a/third_party/WebKit/Source/core/editing/DragCaretController.cpp b/third_party/WebKit/Source/core/editing/DragCaretController.cpp

index 61f97229792aa4a98eaf1cf099db83375786edba..6aff51fb03f422ae06c5a7b2688c1bb0132fa57a 100644

--- a/third_party/WebKit/Source/core/editing/DragCaretController.cpp

+++ b/third_party/WebKit/Source/core/editing/DragCaretController.cpp

@@ -104,7 +104,6 @@ void DragCaretController::nodeWillBeRemoved(Node& node) {

DEFINE_TRACE(DragCaretController) {

visitor->trace(m_position);

- visitor->trace(m_caretBase);

SynchronousMutationObserver::trace(visitor);

}