Change computed style enums to be prefixed with 'k'.

Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will
be changed to have a 'k' prefix. The goal of this CL is to land one
of these changes ahead of time, since the automated tool doesn't
handle rewriting symbols that are declared in generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2614883007
Cr-Commit-Position: refs/heads/master@{#442156}
Committed: https://chromium.googlesource.com/chromium/src/+/dc8651b80ac4d1faf2b864eb9fd01b8a5534ef7b

[nasko, 2017-01-06 15:57:46]

Description was changed from

==========
Change computed style enums to be prefixed with 'k'.


BUG=
==========

to

==========
Change computed style enums to be prefixed with 'k'.


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[nasko, 2017-01-06 15:57:48]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 15:58:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 16:02:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 16:02:33]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[nasko, 2017-01-06 16:33:16]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 16:33:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2017-01-06 16:50:34]

Description was changed from

==========
Change computed style enums to be prefixed with 'k'.


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will be changed
to have a 'k' prefix. The goal of this CL is to land one of these changes ahead
of time, since the automated tool doesn't handle rewriting symbols that are
declared in 
generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[nasko, 2017-01-06 17:06:43]

Description was changed from

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will be changed
to have a 'k' prefix. The goal of this CL is to land one of these changes ahead
of time, since the automated tool doesn't handle rewriting symbols that are
declared in 
generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will be changed
to have a 'k' prefix. The goal of this CL is to land one of these changes ahead
of time, since the automated tool doesn't handle rewriting symbols that are
declared in generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[nasko, 2017-01-06 17:07:13]

nasko@chromium.org changed reviewers:
+ lukasza@chromium.org

[nasko, 2017-01-06 17:07:14]

Hey Lukasz,
Can you review this CL for me?
Thanks in advance!
Nasko

[Łukasz Anforowicz, 2017-01-06 17:28:07]

LGTM - thanks.

https://codereview.chromium.org/2614883007/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp
(right):

https://codereview.chromium.org/2614883007/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp:157:
*os << "EVisibility::kCollapse";
AFAICT the changes in this file are the only place in this CL that changes
behavior.  I think the change is desirable - it only affects how GTest will
print diagnostic messages during a test.

[commit-bot: I haz the power, 2017-01-06 17:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:38:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nasko, 2017-01-06 18:30:28]

nasko@chromium.org changed reviewers:
+ esprehn@chromium.org

[nasko, 2017-01-06 18:30:29]

Hey Elliott,
Can you do an OWNERS review for me?
Thanks in advance!
Nasko

[esprehn, 2017-01-06 20:56:17]

Description was changed from

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will be changed
to have a 'k' prefix. The goal of this CL is to land one of these changes ahead
of time, since the automated tool doesn't handle rewriting symbols that are
declared in generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will
be changed to have a 'k' prefix. The goal of this CL is to land one
of these changes ahead of time, since the automated tool doesn't
handle rewriting symbols that are declared in generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[esprehn, 2017-01-06 20:57:00]

esprehn@chromium.org changed reviewers:
+ sashab@chromium.org

[esprehn, 2017-01-06 20:57:01]

lgtm, sashab@ FYI

[nasko, 2017-01-06 23:54:17]

The CQ bit was checked by nasko@chromium.org

[nasko, 2017-01-06 23:54:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
lukasza@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2614883007/#ps70001
(title: "This should make the Mac be clean.")

[commit-bot: I haz the power, 2017-01-06 23:54:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 23:58:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 23:58:50]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[nasko, 2017-01-07 03:05:11]

The CQ bit was checked by nasko@chromium.org

[nasko, 2017-01-07 03:05:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
lukasza@chromium.org, esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2614883007/#ps90001
(title: "Rebase on ToT.")

[commit-bot: I haz the power, 2017-01-07 03:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 04:37:39]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1483758311525360,
"parent_rev": "566310e3c24f798a9bda03f01cf40edba4d1832a", "commit_rev":
"dc8651b80ac4d1faf2b864eb9fd01b8a5534ef7b"}

[commit-bot: I haz the power, 2017-01-07 04:38:07]

Description was changed from

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will
be changed to have a 'k' prefix. The goal of this CL is to land one
of these changes ahead of time, since the automated tool doesn't
handle rewriting symbols that are declared in generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change computed style enums to be prefixed with 'k'.

As part of the Blink rewrite to match Chromium style, all enums will
be changed to have a 'k' prefix. The goal of this CL is to land one
of these changes ahead of time, since the automated tool doesn't
handle rewriting symbols that are declared in generated code.

BUG=678974
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2614883007
Cr-Commit-Position: refs/heads/master@{#442156}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc8651b80ac4d1faf2b864eb9fd0...
==========

[commit-bot: I haz the power, 2017-01-07 04:38:09]

Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/dc8651b80ac4d1faf2b864eb9fd0...