Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)

Created:
3 years, 11 months ago by nasko
Modified:
3 years, 11 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, ajuma+watch-canvas_chromium.org, ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-api_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, cbiesinger, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtseng+watch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, Eric Willigers, f(malita), fs, glebl+reviews_chromium.org, gasubic, gyuyoung2, haraken, jbroman, jchaffraix+rendering, je_julie, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, leviw+bidiwatch_chromium.org, mlamouri+watch-blink_chromium.org, nektarios, nektar+watch_chromium.org, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, nessy, szager+layoutwatch_chromium.org, vcarbune.chromium, yuzo+watch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change computed style enums to be prefixed with 'k'. As part of the Blink rewrite to match Chromium style, all enums will be changed to have a 'k' prefix. The goal of this CL is to land one of these changes ahead of time, since the automated tool doesn't handle rewriting symbols that are declared in generated code. BUG=678974 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2614883007 Cr-Commit-Position: refs/heads/master@{#442156} Committed: https://chromium.googlesource.com/chromium/src/+/dc8651b80ac4d1faf2b864eb9fd01b8a5534ef7b

Patch Set 1 #

Patch Set 2 : Rebase on ToT. #

Total comments: 1

Patch Set 3 : Fix missed Mac only file. #

Patch Set 4 : Another Mac miss :( #

Patch Set 5 : This should make the Mac be clean. #

Patch Set 6 : Rebase on ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1182 lines, -1171 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableVisibility.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 27 chunks +237 lines, -237 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperty.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 5 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionModifier.cpp View 1 11 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 22 chunks +33 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/TextControlElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 10 chunks +30 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 2 3 4 5 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 2 chunks +57 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMenuList.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 4 5 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 6 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextTest.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ListMarkerText.cpp View 16 chunks +173 lines, -173 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PointerEventsHitRules.cpp View 1 chunk +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextRunConstructor.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineIterator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_bidi_paragraph.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 25 chunks +29 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 7 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder_test.cc View 6 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units_test.cc View 2 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/DetailsMarkerPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FieldsetPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/FileUploadControlPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ReplacedPainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RootInlineBoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGContainerPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePainter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterMac.mm View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 2 3 4 5 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DragImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LengthBox.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebTextRun.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp View 1 2 3 4 5 11 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiCharacterRun.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 1 2 3 4 5 7 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolverTest.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiTextRun.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/Character.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextDirection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextRun.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/text/WritingMode.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormControlElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameContentDumper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebTextDirection.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (22 generated)
nasko
Hey Lukasz, Can you review this CL for me? Thanks in advance! Nasko
3 years, 11 months ago (2017-01-06 17:07:14 UTC) #11
Łukasz Anforowicz
LGTM - thanks. https://codereview.chromium.org/2614883007/diff/20001/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp File third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp (right): https://codereview.chromium.org/2614883007/diff/20001/third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp#newcode157 third_party/WebKit/Source/core/animation/animatable/AnimatableValueTestHelper.cpp:157: *os << "EVisibility::kCollapse"; AFAICT the changes ...
3 years, 11 months ago (2017-01-06 17:28:07 UTC) #12
nasko
Hey Elliott, Can you do an OWNERS review for me? Thanks in advance! Nasko
3 years, 11 months ago (2017-01-06 18:30:29 UTC) #16
esprehn
lgtm, sashab@ FYI
3 years, 11 months ago (2017-01-06 20:57:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614883007/70001
3 years, 11 months ago (2017-01-06 23:54:51 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/131761) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-06 23:58:50 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2614883007/90001
3 years, 11 months ago (2017-01-07 03:05:29 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 04:38:09 UTC) #30
Message was sent while issue was closed.
Committed patchset #6 (id:90001) as
https://chromium.googlesource.com/chromium/src/+/dc8651b80ac4d1faf2b864eb9fd0...

Powered by Google App Engine
This is Rietveld 408576698