Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: third_party/WebKit/Source/web/PopupMenuImpl.cpp

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)
Patch Set: Rebase on ToT. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/PopupMenuImpl.cpp
diff --git a/third_party/WebKit/Source/web/PopupMenuImpl.cpp b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
index c7c38399e713117e2c9dce0d954fe3e8f44f2a1d..61cfe9345ea52ece8b197019ea5463aa5b7a43a3 100644
--- a/third_party/WebKit/Source/web/PopupMenuImpl.cpp
+++ b/third_party/WebKit/Source/web/PopupMenuImpl.cpp
@@ -74,13 +74,13 @@ const char* fontStyleToString(FontStyle style) {
const char* textTransformToString(ETextTransform transform) {
switch (transform) {
- case ETextTransform::Capitalize:
+ case ETextTransform::kCapitalize:
return "capitalize";
- case ETextTransform::Uppercase:
+ case ETextTransform::kUppercase:
return "uppercase";
- case ETextTransform::Lowercase:
+ case ETextTransform::kLowercase:
return "lowercase";
- case ETextTransform::None:
+ case ETextTransform::kNone:
return "none";
}
NOTREACHED();
@@ -315,7 +315,7 @@ void PopupMenuImpl::addElementStyle(ItemIterationContext& context,
// TODO(tkent): We generate unnecessary "style: {\n},\n" even if no
// additional style.
PagePopupClient::addString("style: {\n", data);
- if (style->visibility() == EVisibility::Hidden)
+ if (style->visibility() == EVisibility::kHidden)
addProperty("visibility", String("hidden"), data);
if (style->display() == EDisplay::None)
addProperty("display", String("none"), data);
@@ -323,7 +323,8 @@ void PopupMenuImpl::addElementStyle(ItemIterationContext& context,
if (baseStyle.direction() != style->direction()) {
addProperty(
"direction",
- String(style->direction() == TextDirection::Rtl ? "rtl" : "ltr"), data);
+ String(style->direction() == TextDirection::kRtl ? "rtl" : "ltr"),
+ data);
}
if (isOverride(style->unicodeBidi()))
addProperty("unicodeBidi", String("bidi-override"), data);
« no previous file with comments | « third_party/WebKit/Source/web/ExternalPopupMenu.cpp ('k') | third_party/WebKit/Source/web/WebFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698