Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)
Patch Set: Rebase on ToT. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
index f7ec35cc87997e27ab5c8ffc26e28d7c3b6f23d4..9b9ec1033bc296e83db31077fc5334de445f4dab 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
@@ -43,7 +43,7 @@ static inline String to16Bit(const char* text, unsigned length) {
TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsLatin) {
String latinCommon = to16Bit("ABC DEF.", 8);
- HarfBuzzShaper shaper(latinCommon.characters16(), 8, TextDirection::Ltr);
+ HarfBuzzShaper shaper(latinCommon.characters16(), 8, TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(1u, testInfo(result)->numberOfRunsForTesting());
@@ -56,7 +56,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsLatin) {
TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsLeadingCommon) {
String leadingCommon = to16Bit("... test", 8);
- HarfBuzzShaper shaper(leadingCommon.characters16(), 8, TextDirection::Ltr);
+ HarfBuzzShaper shaper(leadingCommon.characters16(), 8, TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(1u, testInfo(result)->numberOfRunsForTesting());
@@ -81,7 +81,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsUnicodeVariants) {
{"Not-defined Variants", {0x41, 0xDB40, 0xDDEF}, 3, HB_SCRIPT_LATIN},
};
for (auto& test : testlist) {
- HarfBuzzShaper shaper(test.string, test.length, TextDirection::Ltr);
+ HarfBuzzShaper shaper(test.string, test.length, TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
EXPECT_EQ(1u, testInfo(result)->numberOfRunsForTesting()) << test.name;
@@ -110,7 +110,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsDevanagariCommon) {
UChar devanagariCommonString[] = {0x915, 0x94d, 0x930, 0x28, 0x20, 0x29};
String devanagariCommonLatin(devanagariCommonString, 6);
HarfBuzzShaper shaper(devanagariCommonLatin.characters16(), 6,
- TextDirection::Ltr);
+ TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(2u, testInfo(result)->numberOfRunsForTesting());
@@ -130,7 +130,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsDevanagariCommon) {
TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsDevanagariCommonLatinCommon) {
UChar devanagariCommonLatinString[] = {0x915, 0x94d, 0x930, 0x20,
0x61, 0x62, 0x2E};
- HarfBuzzShaper shaper(devanagariCommonLatinString, 7, TextDirection::Ltr);
+ HarfBuzzShaper shaper(devanagariCommonLatinString, 7, TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(3u, testInfo(result)->numberOfRunsForTesting());
@@ -155,7 +155,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsDevanagariCommonLatinCommon) {
TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsArabicThaiHanLatin) {
UChar mixedString[] = {0x628, 0x64A, 0x629, 0xE20, 0x65E5, 0x62};
- HarfBuzzShaper shaper(mixedString, 6, TextDirection::Ltr);
+ HarfBuzzShaper shaper(mixedString, 6, TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(4u, testInfo(result)->numberOfRunsForTesting());
@@ -186,7 +186,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsArabicThaiHanLatin) {
TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsArabicThaiHanLatinTwice) {
UChar mixedString[] = {0x628, 0x64A, 0x629, 0xE20, 0x65E5, 0x62};
- HarfBuzzShaper shaper(mixedString, 6, TextDirection::Ltr);
+ HarfBuzzShaper shaper(mixedString, 6, TextDirection::kLtr);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(4u, testInfo(result)->numberOfRunsForTesting());
@@ -198,7 +198,7 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsArabicThaiHanLatinTwice) {
TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsArabic) {
UChar arabicString[] = {0x628, 0x64A, 0x629};
- HarfBuzzShaper shaper(arabicString, 3, TextDirection::Rtl);
+ HarfBuzzShaper shaper(arabicString, 3, TextDirection::kRtl);
RefPtr<ShapeResult> result = shaper.shapeResult(&font);
ASSERT_EQ(1u, testInfo(result)->numberOfRunsForTesting());

Powered by Google App Engine
This is Rietveld 408576698