third_party/WebKit/Source/web/ExternalPopupMenu.cpp - Issue 2614883007: Change computed style enums to be prefixed with 'k'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)

Patch Set: Rebase on ToT. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

index 58da87fda7f4fd5943cf4361efbff51f3b574077..153473062dc4788c51d934df21bbf741ab5dcd17 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

@@ -267,7 +267,7 @@ void ExternalPopupMenu::getPopupMenuInfo(WebPopupMenuInfo& info,

static_cast<int>(menuStyle.font().getFontDescription().computedSize());

info.selectedIndex = toExternalPopupMenuItemIndex(

ownerElement.selectedListIndex(), ownerElement);

- info.rightAligned = menuStyle.direction() == TextDirection::Rtl;

+ info.rightAligned = menuStyle.direction() == TextDirection::kRtl;

info.allowMultipleSelection = ownerElement.isMultiple();

if (count < itemCount)

items.shrink(count);