Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_units_test.cc

Issue 2614883007: Change computed style enums to be prefixed with 'k'. (Closed)
Patch Set: Rebase on ToT. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_units.h" 5 #include "core/layout/ng/ng_units.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 namespace { 11 namespace {
12 12
13 TEST(NGUnitsTest, ConvertLogicalOffsetToPhysicalOffset) { 13 TEST(NGUnitsTest, ConvertLogicalOffsetToPhysicalOffset) {
14 NGLogicalOffset logical_offset(LayoutUnit(20), LayoutUnit(30)); 14 NGLogicalOffset logical_offset(LayoutUnit(20), LayoutUnit(30));
15 NGPhysicalSize outer_size(LayoutUnit(300), LayoutUnit(400)); 15 NGPhysicalSize outer_size(LayoutUnit(300), LayoutUnit(400));
16 NGPhysicalSize inner_size(LayoutUnit(5), LayoutUnit(65)); 16 NGPhysicalSize inner_size(LayoutUnit(5), LayoutUnit(65));
17 NGPhysicalOffset offset; 17 NGPhysicalOffset offset;
18 18
19 offset = logical_offset.ConvertToPhysical( 19 offset = logical_offset.ConvertToPhysical(
20 kHorizontalTopBottom, TextDirection::Ltr, outer_size, inner_size); 20 kHorizontalTopBottom, TextDirection::kLtr, outer_size, inner_size);
21 EXPECT_EQ(LayoutUnit(20), offset.left); 21 EXPECT_EQ(LayoutUnit(20), offset.left);
22 EXPECT_EQ(LayoutUnit(30), offset.top); 22 EXPECT_EQ(LayoutUnit(30), offset.top);
23 23
24 offset = logical_offset.ConvertToPhysical( 24 offset = logical_offset.ConvertToPhysical(
25 kHorizontalTopBottom, TextDirection::Rtl, outer_size, inner_size); 25 kHorizontalTopBottom, TextDirection::kRtl, outer_size, inner_size);
26 EXPECT_EQ(LayoutUnit(275), offset.left); 26 EXPECT_EQ(LayoutUnit(275), offset.left);
27 EXPECT_EQ(LayoutUnit(30), offset.top); 27 EXPECT_EQ(LayoutUnit(30), offset.top);
28 28
29 offset = logical_offset.ConvertToPhysical( 29 offset = logical_offset.ConvertToPhysical(
30 kVerticalRightLeft, TextDirection::Ltr, outer_size, inner_size); 30 kVerticalRightLeft, TextDirection::kLtr, outer_size, inner_size);
31 EXPECT_EQ(LayoutUnit(265), offset.left); 31 EXPECT_EQ(LayoutUnit(265), offset.left);
32 EXPECT_EQ(LayoutUnit(20), offset.top); 32 EXPECT_EQ(LayoutUnit(20), offset.top);
33 33
34 offset = logical_offset.ConvertToPhysical( 34 offset = logical_offset.ConvertToPhysical(
35 kVerticalRightLeft, TextDirection::Rtl, outer_size, inner_size); 35 kVerticalRightLeft, TextDirection::kRtl, outer_size, inner_size);
36 EXPECT_EQ(LayoutUnit(265), offset.left); 36 EXPECT_EQ(LayoutUnit(265), offset.left);
37 EXPECT_EQ(LayoutUnit(315), offset.top); 37 EXPECT_EQ(LayoutUnit(315), offset.top);
38 38
39 offset = logical_offset.ConvertToPhysical( 39 offset = logical_offset.ConvertToPhysical(
40 kSidewaysRightLeft, TextDirection::Ltr, outer_size, inner_size); 40 kSidewaysRightLeft, TextDirection::kLtr, outer_size, inner_size);
41 EXPECT_EQ(LayoutUnit(265), offset.left); 41 EXPECT_EQ(LayoutUnit(265), offset.left);
42 EXPECT_EQ(LayoutUnit(20), offset.top); 42 EXPECT_EQ(LayoutUnit(20), offset.top);
43 43
44 offset = logical_offset.ConvertToPhysical( 44 offset = logical_offset.ConvertToPhysical(
45 kSidewaysRightLeft, TextDirection::Rtl, outer_size, inner_size); 45 kSidewaysRightLeft, TextDirection::kRtl, outer_size, inner_size);
46 EXPECT_EQ(LayoutUnit(265), offset.left); 46 EXPECT_EQ(LayoutUnit(265), offset.left);
47 EXPECT_EQ(LayoutUnit(315), offset.top); 47 EXPECT_EQ(LayoutUnit(315), offset.top);
48 48
49 offset = logical_offset.ConvertToPhysical( 49 offset = logical_offset.ConvertToPhysical(
50 kVerticalLeftRight, TextDirection::Ltr, outer_size, inner_size); 50 kVerticalLeftRight, TextDirection::kLtr, outer_size, inner_size);
51 EXPECT_EQ(LayoutUnit(30), offset.left); 51 EXPECT_EQ(LayoutUnit(30), offset.left);
52 EXPECT_EQ(LayoutUnit(20), offset.top); 52 EXPECT_EQ(LayoutUnit(20), offset.top);
53 53
54 offset = logical_offset.ConvertToPhysical( 54 offset = logical_offset.ConvertToPhysical(
55 kVerticalLeftRight, TextDirection::Rtl, outer_size, inner_size); 55 kVerticalLeftRight, TextDirection::kRtl, outer_size, inner_size);
56 EXPECT_EQ(LayoutUnit(30), offset.left); 56 EXPECT_EQ(LayoutUnit(30), offset.left);
57 EXPECT_EQ(LayoutUnit(315), offset.top); 57 EXPECT_EQ(LayoutUnit(315), offset.top);
58 58
59 offset = logical_offset.ConvertToPhysical( 59 offset = logical_offset.ConvertToPhysical(
60 kSidewaysLeftRight, TextDirection::Ltr, outer_size, inner_size); 60 kSidewaysLeftRight, TextDirection::kLtr, outer_size, inner_size);
61 EXPECT_EQ(LayoutUnit(30), offset.left); 61 EXPECT_EQ(LayoutUnit(30), offset.left);
62 EXPECT_EQ(LayoutUnit(315), offset.top); 62 EXPECT_EQ(LayoutUnit(315), offset.top);
63 63
64 offset = logical_offset.ConvertToPhysical( 64 offset = logical_offset.ConvertToPhysical(
65 kSidewaysLeftRight, TextDirection::Rtl, outer_size, inner_size); 65 kSidewaysLeftRight, TextDirection::kRtl, outer_size, inner_size);
66 EXPECT_EQ(LayoutUnit(30), offset.left); 66 EXPECT_EQ(LayoutUnit(30), offset.left);
67 EXPECT_EQ(LayoutUnit(20), offset.top); 67 EXPECT_EQ(LayoutUnit(20), offset.top);
68 } 68 }
69 69
70 // Ideally, this would be tested by NGBoxStrut::ConvertToPhysical, but 70 // Ideally, this would be tested by NGBoxStrut::ConvertToPhysical, but
71 // this has not been implemented yet. 71 // this has not been implemented yet.
72 TEST(NGUnitsTest, ConvertPhysicalStrutToLogical) { 72 TEST(NGUnitsTest, ConvertPhysicalStrutToLogical) {
73 LayoutUnit left{5}, right{10}, top{15}, bottom{20}; 73 LayoutUnit left{5}, right{10}, top{15}, bottom{20};
74 NGPhysicalBoxStrut physical{left, right, top, bottom}; 74 NGPhysicalBoxStrut physical{left, right, top, bottom};
75 75
76 NGBoxStrut logical = 76 NGBoxStrut logical =
77 physical.ConvertToLogical(kHorizontalTopBottom, TextDirection::Ltr); 77 physical.ConvertToLogical(kHorizontalTopBottom, TextDirection::kLtr);
78 EXPECT_EQ(left, logical.inline_start); 78 EXPECT_EQ(left, logical.inline_start);
79 EXPECT_EQ(top, logical.block_start); 79 EXPECT_EQ(top, logical.block_start);
80 80
81 logical = physical.ConvertToLogical(kHorizontalTopBottom, TextDirection::Rtl); 81 logical =
82 physical.ConvertToLogical(kHorizontalTopBottom, TextDirection::kRtl);
82 EXPECT_EQ(right, logical.inline_start); 83 EXPECT_EQ(right, logical.inline_start);
83 EXPECT_EQ(top, logical.block_start); 84 EXPECT_EQ(top, logical.block_start);
84 85
85 logical = physical.ConvertToLogical(kVerticalLeftRight, TextDirection::Ltr); 86 logical = physical.ConvertToLogical(kVerticalLeftRight, TextDirection::kLtr);
86 EXPECT_EQ(top, logical.inline_start); 87 EXPECT_EQ(top, logical.inline_start);
87 EXPECT_EQ(left, logical.block_start); 88 EXPECT_EQ(left, logical.block_start);
88 89
89 logical = physical.ConvertToLogical(kVerticalLeftRight, TextDirection::Rtl); 90 logical = physical.ConvertToLogical(kVerticalLeftRight, TextDirection::kRtl);
90 EXPECT_EQ(bottom, logical.inline_start); 91 EXPECT_EQ(bottom, logical.inline_start);
91 EXPECT_EQ(left, logical.block_start); 92 EXPECT_EQ(left, logical.block_start);
92 93
93 logical = physical.ConvertToLogical(kVerticalRightLeft, TextDirection::Ltr); 94 logical = physical.ConvertToLogical(kVerticalRightLeft, TextDirection::kLtr);
94 EXPECT_EQ(top, logical.inline_start); 95 EXPECT_EQ(top, logical.inline_start);
95 EXPECT_EQ(right, logical.block_start); 96 EXPECT_EQ(right, logical.block_start);
96 97
97 logical = physical.ConvertToLogical(kVerticalRightLeft, TextDirection::Rtl); 98 logical = physical.ConvertToLogical(kVerticalRightLeft, TextDirection::kRtl);
98 EXPECT_EQ(bottom, logical.inline_start); 99 EXPECT_EQ(bottom, logical.inline_start);
99 EXPECT_EQ(right, logical.block_start); 100 EXPECT_EQ(right, logical.block_start);
100 } 101 }
101 102
102 TEST(NGUnitsTest, ShrinkToFit) { 103 TEST(NGUnitsTest, ShrinkToFit) {
103 MinAndMaxContentSizes sizes; 104 MinAndMaxContentSizes sizes;
104 105
105 sizes.min_content = LayoutUnit(100); 106 sizes.min_content = LayoutUnit(100);
106 sizes.max_content = LayoutUnit(200); 107 sizes.max_content = LayoutUnit(200);
107 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(300))); 108 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(300)));
108 109
109 sizes.min_content = LayoutUnit(100); 110 sizes.min_content = LayoutUnit(100);
110 sizes.max_content = LayoutUnit(300); 111 sizes.max_content = LayoutUnit(300);
111 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(200))); 112 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(200)));
112 113
113 sizes.min_content = LayoutUnit(200); 114 sizes.min_content = LayoutUnit(200);
114 sizes.max_content = LayoutUnit(300); 115 sizes.max_content = LayoutUnit(300);
115 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(100))); 116 EXPECT_EQ(LayoutUnit(200), sizes.ShrinkToFit(LayoutUnit(100)));
116 } 117 }
117 118
118 } // namespace 119 } // namespace
119 120
120 } // namespace blink 121 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_units.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698