Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2611773002: Removes code using mus client lib (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul, dcheng, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes code using mus client lib It's no longer used. There is a more cleanup to be done around renaming files. I'll do that after this. This also removes what was views_mus_unittests and renames what was views_aura_mus_unittests to views_mus_unittests. BUG=671363 TEST=none R=ben@chromium.org Committed: https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d Cr-Commit-Position: refs/heads/master@{#441293}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Patch Set 4 : dont run on linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -5310 lines) Patch
M ash/mus/window_manager_application.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 2 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +1 line, -7 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/accessible_pane_view_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 1 1 chunk +11 lines, -14 lines 0 comments Download
M ui/views/controls/button/menu_button_unittest.cc View 1 2 3 chunks +3 lines, -16 lines 0 comments Download
M ui/views/controls/menu/menu_controller_unittest.cc View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M ui/views/controls/menu/menu_runner_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 18 chunks +23 lines, -23 lines 0 comments Download
M ui/views/event_monitor_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/mus/BUILD.gn View 6 chunks +3 lines, -142 lines 0 comments Download
M ui/views/mus/clipboard_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ui/views/mus/drag_drop_client_mus.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/views/mus/drag_drop_client_mus.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/views/mus/drop_target_mus.h View 1 chunk +0 lines, -92 lines 0 comments Download
D ui/views/mus/drop_target_mus.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D ui/views/mus/input_method_mus.h View 1 chunk +0 lines, -77 lines 0 comments Download
D ui/views/mus/input_method_mus.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D ui/views/mus/input_method_mus_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M ui/views/mus/interactive_ui_tests_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ui/views/mus/native_widget_mus.h View 1 chunk +0 lines, -315 lines 0 comments Download
D ui/views/mus/native_widget_mus.cc View 1 chunk +0 lines, -1589 lines 0 comments Download
D ui/views/mus/native_widget_mus_unittest.cc View 1 chunk +0 lines, -684 lines 0 comments Download
D ui/views/mus/pointer_watcher_event_router.h View 1 chunk +0 lines, -79 lines 0 comments Download
D ui/views/mus/pointer_watcher_event_router.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D ui/views/mus/pointer_watcher_event_router_unittest.cc View 1 chunk +0 lines, -245 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/screen_mus_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ui/views/mus/surface_context_factory.h View 1 chunk +0 lines, -50 lines 0 comments Download
D ui/views/mus/surface_context_factory.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M ui/views/mus/test_utils.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/views/mus/text_input_client_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/views/mus/text_input_client_impl.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D ui/views/mus/unittests_aura_manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/views/mus/views_aura_mus_test_suite.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D ui/views/mus/views_mus_test_suite.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/mus/views_mus_test_suite.cc View 1 chunk +0 lines, -195 lines 0 comments Download
D ui/views/mus/window_manager_connection.h View 1 chunk +0 lines, -126 lines 0 comments Download
D ui/views/mus/window_manager_connection.cc View 1 chunk +0 lines, -235 lines 0 comments Download
D ui/views/mus/window_manager_connection_unittest.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D ui/views/mus/window_tree_host_mus.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ui/views/mus/window_tree_host_mus.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D ui/views/test/native_widget_factory_mus.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M ui/views/test/platform_test_helper.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/test/platform_test_helper.cc View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.cc View 1 2 3 chunks +0 lines, -29 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/test/views_test_helper_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 2 13 chunks +13 lines, -13 lines 0 comments Download
M ui/views/touchui/touch_selection_menu_runner_views_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/view_unittest_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_interactive_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 11 chunks +15 lines, -31 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 21 chunks +14 lines, -59 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
sky
3 years, 11 months ago (2017-01-03 22:52:50 UTC) #4
Ben Goodger (Google)
lgtm
3 years, 11 months ago (2017-01-03 23:16:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611773002/40001
3 years, 11 months ago (2017-01-03 23:17:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611773002/60001
3 years, 11 months ago (2017-01-04 00:09:41 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 11 months ago (2017-01-04 02:21:30 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 02:23:54 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/600b41c186e7ab224a8b356dd09226dd7edd7e3d
Cr-Commit-Position: refs/heads/master@{#441293}

Powered by Google App Engine
This is Rietveld 408576698