Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2610063002: Cleanup after removing views-mus code (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup after removing views-mus code PointerWatcherEventRouter2 is now PointerWatcherEventRouter and aura_mus has been renamed to just mus. BUG=671363 TEST=none R=erg@chromium.org Committed: https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4 Cr-Commit-Position: refs/heads/master@{#441321}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -845 lines) Patch
M ash/autoclick/mus/autoclick_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_context_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/interactive_ui_tests_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/mus_client.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/mus_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/views/mus/pointer_watcher_event_router.h View 5 chunks +11 lines, -12 lines 0 comments Download
A + ui/views/mus/pointer_watcher_event_router.cc View 7 chunks +12 lines, -13 lines 0 comments Download
D ui/views/mus/pointer_watcher_event_router2.h View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/views/mus/pointer_watcher_event_router2.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D ui/views/mus/pointer_watcher_event_router2_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
A + ui/views/mus/pointer_watcher_event_router_unittest.cc View 4 chunks +20 lines, -20 lines 0 comments Download
D ui/views/mus/run_all_unittests_aura_mus.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D ui/views/mus/views_aura_mus_test_suite.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/mus/views_aura_mus_test_suite.cc View 1 chunk +0 lines, -215 lines 0 comments Download
A + ui/views/mus/views_mus_test_suite.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/views/mus/views_mus_test_suite.cc View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sky
3 years, 11 months ago (2017-01-04 00:47:59 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/2610063002/diff/1/ui/views/mus/pointer_watcher_event_router.h File ui/views/mus/pointer_watcher_event_router.h (left): https://codereview.chromium.org/2610063002/diff/1/ui/views/mus/pointer_watcher_event_router.h#oldcode32 ui/views/mus/pointer_watcher_event_router.h:32: // TODO(sky): Nuke existing PointerWatcherEventRouter and rename this. ...
3 years, 11 months ago (2017-01-04 00:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610063002/20001
3 years, 11 months ago (2017-01-04 03:57:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 05:05:47 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 05:10:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a4477cb3b7262d57996862efcebe612a365706d4
Cr-Commit-Position: refs/heads/master@{#441321}

Powered by Google App Engine
This is Rietveld 408576698