Use exact pixel sizes instead of dip in webapp/WebAPK installability code

Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

Originally patched from https://codereview.chromium.org/2589503002/.

BUG=675765
Review-Url: https://codereview.chromium.org/2611623003
Cr-Commit-Position: refs/heads/master@{#441659}
Committed: https://chromium.googlesource.com/chromium/src/+/5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499

[F, 2017-01-03 23:02:29]

Description was changed from

==========
Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

BUG=675765
==========

to

==========
Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

BUG=675765
==========

[F, 2017-01-03 23:35:11]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:35:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-01-03 23:41:24]

zpeng@chromium.org changed reviewers:
+ dominickn@chromium.org, mlamouri@chromium.org

[F, 2017-01-03 23:41:25]

Hi Dominick & Mounir, PTAL. Thanks!

I take over this CL from pkotwicz@ since he's been out of office. The patch#1 is
the latest patch from Peter's CL on https://codereview.chromium.org/2589503002/,
which you have already LGTM-ed. Even though it would pass all try jobs, it could
not be landed due to patch error on
chrome/browser/android/webapk/webapk_update_data_fetcher.cc. However, the patch
can be applied locally on the latest master branch.

[dominickn, 2017-01-04 00:13:13]

On 2017/01/03 23:41:25, F wrote:
> Hi Dominick & Mounir, PTAL. Thanks!
> 
> I take over this CL from pkotwicz@ since he's been out of office. The patch#1
is
> the latest patch from Peter's CL on
https://codereview.chromium.org/2589503002/,
> which you have already LGTM-ed. Even though it would pass all try jobs, it
could
> not be landed due to patch error on
> chrome/browser/android/webapk/webapk_update_data_fetcher.cc. However, the
patch
> can be applied locally on the latest master branch.

This looks like an infrastructure issue. The patch errors on the ios bot are all
of the form:

Applying the patch from https://codereview.chromium.org/2589503002/#ps60001
Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:
While running git apply --index -3 -p1 --verbose;
  Created missing directory chrome/android/java/src/org/chromium/chrome/browser.
  Checking patch
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java...
  error:
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java: does
not exist in index

I think that bot is broken and the original patch is fine. I'll ping infra and
see if they know anything...

[dominickn, 2017-01-04 00:45:39]

I'm following up with agable - this is definitely a bot issue. The iOS bot
that's failing is very messed up at the moment.

You should be able to close this issue and use the other one to reland once the
bot issue is fixed up.

[commit-bot: I haz the power, 2017-01-04 00:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:55:17]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-01-04 01:27:40]

On 2017/01/04 00:45:39, dominickn wrote:
> I'm following up with agable - this is definitely a bot issue. The iOS bot
> that's failing is very messed up at the moment.
> 
> You should be able to close this issue and use the other one to reland once
the
> bot issue is fixed up.

So it turns out that the messed up bot is a red herring. You actually need to
rebase this patch against master

The bots fall back to a 3-way merge, so they're able to make the patch apply.
However, the CQ itself does not use the 3 way merge, so the patch fails to apply
there.

[F, 2017-01-04 14:53:29]

Description was changed from

==========
Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

BUG=675765
==========

to

==========
Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

Originally patched from https://codereview.chromium.org/2589503002/.

BUG=675765
==========

[F, 2017-01-04 15:03:12]

On 2017/01/04 01:27:40, dominickn wrote:
> On 2017/01/04 00:45:39, dominickn wrote:
> > I'm following up with agable - this is definitely a bot issue. The iOS bot
> > that's failing is very messed up at the moment.
> > 
> > You should be able to close this issue and use the other one to reland once
> the
> > bot issue is fixed up.
> 
> So it turns out that the messed up bot is a red herring. You actually need to
> rebase this patch against master
> 
> The bots fall back to a 3-way merge, so they're able to make the patch apply.
> However, the CQ itself does not use the 3 way merge, so the patch fails to
apply
> there.

Hi Dominick,

Patch #1 is rebased on master. The line numbers in
chrome/browser/android/webapk/webapk_update_data_fetcher.cc. are different. When
I run "git cl patch 2589503002" on a new branch, the 3-way merge applies the
patch correctly. As a result, "git rebase master" has no effect.

I think this CL is good to go. WDUT?

[mlamouri (slow - plz ping), 2017-01-04 16:00:50]

still lgtm

[dominickn, 2017-01-04 23:36:09]

On 2017/01/04 15:03:12, F wrote:
> On 2017/01/04 01:27:40, dominickn wrote:
> > On 2017/01/04 00:45:39, dominickn wrote:
> > > I'm following up with agable - this is definitely a bot issue. The iOS bot
> > > that's failing is very messed up at the moment.
> > > 
> > > You should be able to close this issue and use the other one to reland
once
> > the
> > > bot issue is fixed up.
> > 
> > So it turns out that the messed up bot is a red herring. You actually need
to
> > rebase this patch against master
> > 
> > The bots fall back to a 3-way merge, so they're able to make the patch
apply.
> > However, the CQ itself does not use the 3 way merge, so the patch fails to
> apply
> > there.
> 
> Hi Dominick,
> 
> Patch #1 is rebased on master. The line numbers in
> chrome/browser/android/webapk/webapk_update_data_fetcher.cc. are different.
When
> I run "git cl patch 2589503002" on a new branch, the 3-way merge applies the
> patch correctly. As a result, "git rebase master" has no effect.
> 
> I think this CL is good to go. WDUT?

The CQ does not use a 3-way merge, but the trybots do. That's why the patch
fails, and that's why you need to rebase onto the latest master. (3-way merge is
disabled on the CQ because it leads to problems like patches landing twice).

[dominickn, 2017-01-05 04:29:27]

Also, still lgtm

[F, 2017-01-05 14:38:21]

The CQ bit was checked by zpeng@chromium.org

[commit-bot: I haz the power, 2017-01-05 14:38:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 15:45:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483627101110250, "parent_rev":
"414682ab737e7b41e4bf73f6cff42e75c5d73a42", "commit_rev":
"5d8fdfc2f5c4f3c6d92c716f44f6c13ebb6af499"}

[commit-bot: I haz the power, 2017-01-05 15:45:40]

Description was changed from

==========
Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

Originally patched from https://codereview.chromium.org/2589503002/.

BUG=675765
==========

to

==========
Use exact pixel sizes instead of dip in webapp/WebAPK installability code

This CL:
- Makes the members of InstallableManager::InstallableParams use pixel units
  instead of device independent pixel units
- Removes unnecessary conversions between pixels and device independent pixel
  units

Note: android.content.res.Resources#getDimension() multiplies the device
independent pixel measurement in resources by the current device scale factor

Originally patched from https://codereview.chromium.org/2589503002/.

BUG=675765

Review-Url: https://codereview.chromium.org/2611623003
Cr-Commit-Position: refs/heads/master@{#441659}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d8fdfc2f5c4f3c6d92c716f44f6...
==========

[commit-bot: I haz the power, 2017-01-05 15:45:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d8fdfc2f5c4f3c6d92c716f44f6...