Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5395)

Unified Diff: chrome/browser/manifest/manifest_icon_downloader.h

Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)
Patch Set: Rebased version of pkotwicz@'s original patch Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/manifest/manifest_icon_downloader.h
diff --git a/chrome/browser/manifest/manifest_icon_downloader.h b/chrome/browser/manifest/manifest_icon_downloader.h
index ec7a66a481115082bd14d1e0de53aacfaa997c61..d1ed7de9716dce46197d3e576247d438081db9cb 100644
--- a/chrome/browser/manifest/manifest_icon_downloader.h
+++ b/chrome/browser/manifest/manifest_icon_downloader.h
@@ -24,10 +24,10 @@ class GURL;
// Helper class which downloads the icon located at a specified. If the icon
// file contains multiple icons then it attempts to pick the one closest in size
-// bigger than or equal to ideal_icon_size_in_dp, taking into account the
+// bigger than or equal to ideal_icon_size_in_px, taking into account the
// density of the device. If a bigger icon is chosen then, the icon is scaled
-// down to be equal to ideal_icon_size_in_dp. Smaller icons will be chosen down
-// to the value specified by |minimum_icon_size_in_dp|.
+// down to be equal to ideal_icon_size_in_px. Smaller icons will be chosen down
+// to the value specified by |minimum_icon_size_in_px|.
class ManifestIconDownloader final {
public:
using IconFetchCallback = base::Callback<void(const SkBitmap&)>;
@@ -40,8 +40,8 @@ class ManifestIconDownloader final {
// download the image.
static bool Download(content::WebContents* web_contents,
const GURL& icon_url,
- int ideal_icon_size_in_dp,
- int minimum_icon_size_in_dp,
+ int ideal_icon_size_in_px,
+ int minimum_icon_size_in_px,
const IconFetchCallback& callback);
private:
« no previous file with comments | « chrome/browser/installable/installable_manager_browsertest.cc ('k') | chrome/browser/manifest/manifest_icon_downloader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698