Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)
Patch Set: Rebased version of pkotwicz@'s original patch Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index 0f0075fb31a96916278826eb8651d2a06752e6b5..20de87adca0e94c373a626207b7e892e97e929f8 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -69,10 +69,10 @@ class AddToHomescreenDataFetcher
// the renderer process. The initialization is asynchronous and
// OnDidGetWebApplicationInfo is expected to be called when finished.
AddToHomescreenDataFetcher(content::WebContents* web_contents,
- int ideal_icon_size_in_dp,
- int minimum_icon_size_in_dp,
- int ideal_splash_image_size_in_dp,
- int minimum_splash_image_size_in_dp,
+ int ideal_icon_size_in_px,
+ int minimum_icon_size_in_px,
+ int ideal_splash_image_size_in_px,
+ int minimum_splash_image_size_in_px,
bool check_webapk_compatible,
Observer* observer);
@@ -131,10 +131,10 @@ class AddToHomescreenDataFetcher
base::CancelableTaskTracker favicon_task_tracker_;
base::Timer data_timeout_timer_;
- const int ideal_icon_size_in_dp_;
- const int minimum_icon_size_in_dp_;
- const int ideal_splash_image_size_in_dp_;
- const int minimum_splash_image_size_in_dp_;
+ const int ideal_icon_size_in_px_;
+ const int minimum_icon_size_in_px_;
+ const int ideal_splash_image_size_in_px_;
+ const int minimum_splash_image_size_in_px_;
// Indicates whether to check WebAPK compatibility.
bool check_webapk_compatibility_;

Powered by Google App Engine
This is Rietveld 408576698