Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)
Patch Set: Rebased version of pkotwicz@'s original patch Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 base::Closure FetchWebappSplashScreenImageCallback( 61 base::Closure FetchWebappSplashScreenImageCallback(
62 const std::string& webapp_id) override; 62 const std::string& webapp_id) override;
63 63
64 // Registers native methods. 64 // Registers native methods.
65 static bool Register(JNIEnv* env); 65 static bool Register(JNIEnv* env);
66 66
67 protected: 67 protected:
68 // AppBannerManager overrides. 68 // AppBannerManager overrides.
69 std::string GetAppIdentifier() override; 69 std::string GetAppIdentifier() override;
70 std::string GetBannerType() override; 70 std::string GetBannerType() override;
71 int GetIdealIconSizeInDp() override; 71 int GetIdealIconSizeInPx() override;
72 int GetMinimumIconSizeInDp() override; 72 int GetMinimumIconSizeInPx() override;
73 bool IsWebAppInstalled(content::BrowserContext* browser_context, 73 bool IsWebAppInstalled(content::BrowserContext* browser_context,
74 const GURL& start_url) override; 74 const GURL& start_url) override;
75 75
76 void PerformInstallableCheck() override; 76 void PerformInstallableCheck() override;
77 void OnAppIconFetched(const SkBitmap& bitmap) override; 77 void OnAppIconFetched(const SkBitmap& bitmap) override;
78 void ShowBanner() override; 78 void ShowBanner() override;
79 79
80 private: 80 private:
81 friend class content::WebContentsUserData<AppBannerManagerAndroid>; 81 friend class content::WebContentsUserData<AppBannerManagerAndroid>;
82 82
(...skipping 25 matching lines...) Expand all
108 108
109 // App package name for a native app banner. 109 // App package name for a native app banner.
110 std::string native_app_package_; 110 std::string native_app_package_;
111 111
112 DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid); 112 DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid);
113 }; 113 };
114 114
115 } // namespace banners 115 } // namespace banners
116 116
117 #endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ 117 #endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698