chrome/browser/android/banners/app_banner_manager_android.h - Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)

Patch Set: Rebased version of pkotwicz@'s original patch Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_manager_android.h

diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h

index 29750ed030f6765b1efad5d436068874ef5081c2..3ad2d27a67be6314127cb2d1b220673cb2e365fd 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.h

+++ b/chrome/browser/android/banners/app_banner_manager_android.h

@@ -68,8 +68,8 @@ class AppBannerManagerAndroid

// AppBannerManager overrides.

std::string GetAppIdentifier() override;

std::string GetBannerType() override;

- int GetIdealIconSizeInDp() override;

- int GetMinimumIconSizeInDp() override;

+ int GetIdealIconSizeInPx() override;

+ int GetMinimumIconSizeInPx() override;

bool IsWebAppInstalled(content::BrowserContext* browser_context,

const GURL& start_url) override;