chrome/browser/banners/app_banner_manager.h - Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2611623003: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)

Patch Set: Rebased version of pkotwicz@'s original patch Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/banners/app_banner_manager.h

diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h

index 06fba428c46910f7012177c1afba35247b7efc8b..112b6178468a6b043882e9f9c6cc077eee86f439 100644

--- a/chrome/browser/banners/app_banner_manager.h

+++ b/chrome/browser/banners/app_banner_manager.h

@@ -116,8 +116,8 @@ class AppBannerManager : public content::WebContentsObserver,

std::string GetStatusParam(InstallableStatusCode code);

// Returns the ideal and minimum icon sizes required for being installable.

- virtual int GetIdealIconSizeInDp();

- virtual int GetMinimumIconSizeInDp();

+ virtual int GetIdealIconSizeInPx();

+ virtual int GetMinimumIconSizeInPx();

// Returns a WeakPtr to this object. Exposed so subclasses/infobars may

// may bind callbacks without needing their own WeakPtrFactory.