SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None

Committed: https://crrev.com/a1b6a7e45fe530ca5e3c5ab026aa35cb2b2e05da
Cr-Commit-Position: refs/heads/master@{#441375}

[sdefresne, 2017-01-03 17:43:11]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 17:43:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-03 17:44:10]

sdefresne@chromium.org changed reviewers:
+ msarda@chromium.org

[sdefresne, 2017-01-03 17:44:11]

Can you take a look as OWNERS of the updated API?

[Avi (use Gerrit), 2017-01-03 17:45:48]

drive-by woot

Woot!

[commit-bot: I haz the power, 2017-01-03 18:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:48:08]

Dry run: This issue passed the CQ dry run.

[msarda, 2017-01-04 09:59:11]

The CQ bit was checked by msarda@chromium.org

[msarda, 2017-01-04 09:59:12]

lgtm

[msarda, 2017-01-04 09:59:22]

The CQ bit was unchecked by msarda@chromium.org

[sdefresne, 2017-01-04 13:44:42]

Description was changed from

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None
==========

to

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None
TBR=asvitkine@chromium.org
==========

[sdefresne, 2017-01-04 13:44:42]

sdefresne@chromium.org changed reviewers:
+ asvitkine@chromium.org

[sdefresne, 2017-01-04 13:44:59]

Description was changed from

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None
TBR=asvitkine@chromium.org
==========

to

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None
==========

[sdefresne, 2017-01-04 13:45:16]

asvitkine: can you review as OWNERS of chrome/browser/metrics?

[Alexei Svitkine (slow), 2017-01-04 15:05:44]

lgtm

[sdefresne, 2017-01-04 15:09:48]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-04 15:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 15:14:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483542588930950, "parent_rev":
"6b12de9d41a38f43675c7af53dd899123de329a4", "commit_rev":
"ecb49ac7a58c27ccdc32b8f9fd3e5b6eed735254"}

[commit-bot: I haz the power, 2017-01-04 15:14:49]

Description was changed from

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None
==========

to

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None

Review-Url: https://codereview.chromium.org/2609213002
==========

[commit-bot: I haz the power, 2017-01-04 15:14:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 15:16:53]

Description was changed from

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None

Review-Url: https://codereview.chromium.org/2609213002
==========

to

==========
SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Since SigninStatusMetricsProvider::CreateInstance returns a newly
created object owned by the caller, enforce this by returning a
std::unique_ptr<> instead of a raw pointer.

Remove unnecessary calls to base::WrapUnique() after this API change.

BUG=None

Committed: https://crrev.com/a1b6a7e45fe530ca5e3c5ab026aa35cb2b2e05da
Cr-Commit-Position: refs/heads/master@{#441375}
==========

[commit-bot: I haz the power, 2017-01-04 15:16:54]

Patchset 1 (id:??) landed as
https://crrev.com/a1b6a7e45fe530ca5e3c5ab026aa35cb2b2e05da
Cr-Commit-Position: refs/heads/master@{#441375}