Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes. Also
remove the helper method ::IsOffTheRecordSessionActive and directly
call the real implementation from BrowserListIOS.

Convert naked "new" call initializing std::unique_ptr<> to instead
use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)").

BUG=676278
Committed: https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3
Cr-Commit-Position: refs/heads/master@{#441373}

[sdefresne, 2017-01-03 17:34:22]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-01-03 17:34:31]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-01-03 17:34:32]

Please take a look.

[commit-bot: I haz the power, 2017-01-03 17:34:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 18:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:25:06]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-04 12:44:01]

lgtm

https://codereview.chromium.org/2615433002/diff/1/ios/chrome/browser/metrics/...
File ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm (right):

https://codereview.chromium.org/2615433002/diff/1/ios/chrome/browser/metrics/...
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm:207:
metrics_service_->RegisterMetricsProvider(
Can this move outside the braces?

[sdefresne, 2017-01-04 13:56:35]

Thank you for the review.

https://codereview.chromium.org/2615433002/diff/1/ios/chrome/browser/metrics/...
File ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm (right):

https://codereview.chromium.org/2615433002/diff/1/ios/chrome/browser/metrics/...
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm:207:
metrics_service_->RegisterMetricsProvider(
On 2017/01/04 12:44:01, rohitrao wrote:
> Can this move outside the braces?

Yes, good catch.

[sdefresne, 2017-01-04 13:57:19]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-04 13:57:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2615433002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-01-04 13:57:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 14:51:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483538239703020,
"parent_rev": "f3ab3e2bfe491179cf09f42d99aaff2c1460cba4", "commit_rev":
"d5f483de9bbafb7c67db249ed9945524e40feecf"}

[commit-bot: I haz the power, 2017-01-04 14:51:47]

Description was changed from

==========
Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes. Also
remove the helper method ::IsOffTheRecordSessionActive and directly
call the real implementation from BrowserListIOS.

Convert naked "new" call initializing std::unique_ptr<> to instead
use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)").

BUG=676278
==========

to

==========
Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes. Also
remove the helper method ::IsOffTheRecordSessionActive and directly
call the real implementation from BrowserListIOS.

Convert naked "new" call initializing std::unique_ptr<> to instead
use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)").

BUG=676278

Review-Url: https://codereview.chromium.org/2615433002
==========

[commit-bot: I haz the power, 2017-01-04 14:51:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 14:54:35]

Description was changed from

==========
Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes. Also
remove the helper method ::IsOffTheRecordSessionActive and directly
call the real implementation from BrowserListIOS.

Convert naked "new" call initializing std::unique_ptr<> to instead
use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)").

BUG=676278

Review-Url: https://codereview.chromium.org/2615433002
==========

to

==========
Remove ChromeBrowserProvider::IsOffTheRecordSessionActive().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes. Also
remove the helper method ::IsOffTheRecordSessionActive and directly
call the real implementation from BrowserListIOS.

Convert naked "new" call initializing std::unique_ptr<> to instead
use "base::MakeUnique" (ditto for "base::WrapUnique(new ...)").

BUG=676278

Committed: https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3
Cr-Commit-Position: refs/heads/master@{#441373}
==========

[commit-bot: I haz the power, 2017-01-04 14:54:36]

Patchset 2 (id:??) landed as
https://crrev.com/4f378a75463a07e4120477599a9e9600f9d2f4f3
Cr-Commit-Position: refs/heads/master@{#441373}