components/signin/core/browser/signin_status_metrics_provider.h - Issue 2609213002: SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/signin_status_metrics_provider.h

Issue 2609213002: SigninStatusMetricsProvider factory returns a std::unique_ptr<>. (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/signin_status_metrics_provider.h

diff --git a/components/signin/core/browser/signin_status_metrics_provider.h b/components/signin/core/browser/signin_status_metrics_provider.h

index 859363ea813a3cd535631ce5929d1da80a08d2d4..9d6e663d12691e5e01b0600b310afd94b441573a 100644

--- a/components/signin/core/browser/signin_status_metrics_provider.h

+++ b/components/signin/core/browser/signin_status_metrics_provider.h

@@ -37,7 +37,7 @@ class SigninStatusMetricsProvider : public SigninStatusMetricsProviderBase,

metrics::ChromeUserMetricsExtension* uma_proto) override;

// Factory method, creates a new instance of this class.

- static SigninStatusMetricsProvider* CreateInstance(

+ static std::unique_ptr<SigninStatusMetricsProvider> CreateInstance(

std::unique_ptr<SigninStatusMetricsProviderDelegate> delegate);

// Update the sign-in status when a SigninManager is created.