chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc - Issue 2609213002: SigninStatusMetricsProvider factory returns a std::unique_ptr<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc

Issue 2609213002: SigninStatusMetricsProvider factory returns a std::unique_ptr<>. (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.cc ('k') | components/signin/core/browser/signin_status_metrics_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc

diff --git a/chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc b/chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc

index 962c98fb8e9e483be4dae85b6d6afb2a5b9a09a7..1291a5911f9d07f48559053258956c53834d4eb4 100644

--- a/chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc

+++ b/chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc

@@ -19,8 +19,8 @@ TEST(ChromeSigninStatusMetricsProviderDelegateTest,

std::unique_ptr<ChromeSigninStatusMetricsProviderDelegate> delegate(

new ChromeSigninStatusMetricsProviderDelegate);

ChromeSigninStatusMetricsProviderDelegate* raw_delegate = delegate.get();

- std::unique_ptr<SigninStatusMetricsProvider> metrics_provider(

- SigninStatusMetricsProvider::CreateInstance(std::move(delegate)));

+ std::unique_ptr<SigninStatusMetricsProvider> metrics_provider =

+ SigninStatusMetricsProvider::CreateInstance(std::move(delegate));

// Initial status is all signed in and then a signed-in browser is opened.

metrics_provider->UpdateInitialSigninStatusForTesting(2, 2);