Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2609213002: SigninStatusMetricsProvider factory returns a std::unique_ptr<>. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 // recorded yet. 677 // recorded yet.
678 if (metrics::GetMetricsReportingDefaultState(local_state) == 678 if (metrics::GetMetricsReportingDefaultState(local_state) ==
679 metrics::EnableMetricsDefault::DEFAULT_UNKNOWN) { 679 metrics::EnableMetricsDefault::DEFAULT_UNKNOWN) {
680 metrics::RecordMetricsReportingDefaultState( 680 metrics::RecordMetricsReportingDefaultState(
681 local_state, metrics::EnableMetricsDefault::OPT_OUT); 681 local_state, metrics::EnableMetricsDefault::OPT_OUT);
682 } 682 }
683 #endif // defined(OS_CHROMEOS) 683 #endif // defined(OS_CHROMEOS)
684 684
685 #if !defined(OS_CHROMEOS) 685 #if !defined(OS_CHROMEOS)
686 metrics_service_->RegisterMetricsProvider( 686 metrics_service_->RegisterMetricsProvider(
687 std::unique_ptr<metrics::MetricsProvider>( 687 SigninStatusMetricsProvider::CreateInstance(
688 SigninStatusMetricsProvider::CreateInstance(base::WrapUnique( 688 base::WrapUnique(new ChromeSigninStatusMetricsProviderDelegate)));
689 new ChromeSigninStatusMetricsProviderDelegate))));
690 #endif // !defined(OS_CHROMEOS) 689 #endif // !defined(OS_CHROMEOS)
691 690
692 metrics_service_->RegisterMetricsProvider( 691 metrics_service_->RegisterMetricsProvider(
693 std::unique_ptr<metrics::MetricsProvider>( 692 std::unique_ptr<metrics::MetricsProvider>(
694 new syncer::DeviceCountMetricsProvider(base::Bind( 693 new syncer::DeviceCountMetricsProvider(base::Bind(
695 &browser_sync::ChromeSyncClient::GetDeviceInfoTrackers)))); 694 &browser_sync::ChromeSyncClient::GetDeviceInfoTrackers))));
696 695
697 metrics_service_->RegisterMetricsProvider( 696 metrics_service_->RegisterMetricsProvider(
698 std::unique_ptr<metrics::MetricsProvider>( 697 std::unique_ptr<metrics::MetricsProvider>(
699 new HttpsEngagementMetricsProvider())); 698 new HttpsEngagementMetricsProvider()));
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 } 893 }
895 } 894 }
896 895
897 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) { 896 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) {
898 metrics_service_->OnApplicationNotIdle(); 897 metrics_service_->OnApplicationNotIdle();
899 } 898 }
900 899
901 bool ChromeMetricsServiceClient::IsUMACellularUploadLogicEnabled() { 900 bool ChromeMetricsServiceClient::IsUMACellularUploadLogicEnabled() {
902 return metrics::IsCellularLogicEnabled(); 901 return metrics::IsCellularLogicEnabled();
903 } 902 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/signin/chrome_signin_status_metrics_provider_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698