Remove ChromeBrowserProvider::GetFaviconForURL().

Remove ChromeBrowserProvider::GetFaviconForURL().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes.

Move the implementation of GetFaviconForNativeApplicationURL() from
ChromeWebUIIOSControllerFactory to FaviconClientImpl to untangle a
complex and deep circular dependencies causing linker failures when
removing DownstreamChromiumBrowserProvider.

BUG=676278
Review-Url: https://codereview.chromium.org/2609363003
Cr-Commit-Position: refs/heads/master@{#442208}
Committed: https://chromium.googlesource.com/chromium/src/+/a7f6a8a960a2078be95065df1c713f0c16887763

[sdefresne, 2017-01-04 10:17:38]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-01-04 10:17:47]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-01-04 10:17:48]

Please take a look.

[commit-bot: I haz the power, 2017-01-04 10:17:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 12:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 12:21:35]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-04 12:36:06]

lgtm

https://codereview.chromium.org/2609363003/diff/1/ios/chrome/browser/favicon/...
File ios/chrome/browser/favicon/BUILD.gn (right):

https://codereview.chromium.org/2609363003/diff/1/ios/chrome/browser/favicon/...
ios/chrome/browser/favicon/BUILD.gn:27: deps = [
Should this depend on //ios/chrome/browser/ui/webui?

[sdefresne, 2017-01-04 14:01:35]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 14:01:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-04 14:05:43]

On 2017/01/04 12:36:06, rohitrao wrote:
> lgtm
> 
>
https://codereview.chromium.org/2609363003/diff/1/ios/chrome/browser/favicon/...
> File ios/chrome/browser/favicon/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2609363003/diff/1/ios/chrome/browser/favicon/...
> ios/chrome/browser/favicon/BUILD.gn:27: deps = [
> Should this depend on //ios/chrome/browser/ui/webui?

No, that would create a circular dependency, this is why we have a
allow_circular_includes_from ios/chrome/browser/ui/webui/BUILD.gn.

[sdefresne, 2017-01-04 14:59:38]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2017-01-04 14:59:43]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-04 14:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2609363003/#ps20001
(title: "Rebase on https://codereview.chromium.org/2615433002.")

[commit-bot: I haz the power, 2017-01-04 14:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-04 15:54:35]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2017-01-05 10:41:51]

Description was changed from

==========
Remove ChromeBrowserProvider::GetFaviconForURL().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes.

BUG=676278
==========

to

==========
Remove ChromeBrowserProvider::GetFaviconForURL().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes.

Move the implementation of GetFaviconForNativeApplicationURL() from
ChromeWebUIIOSControllerFactory to FaviconClientImpl to untangle a
complex and deep circular dependencies causing linker failures when
removing DownstreamChromiumBrowserProvider.

BUG=676278
==========

[sdefresne, 2017-01-05 10:45:32]

Please take another look as I did a large refactoring with patchset #2 to remove
the circular dependency as allow_circular_includes_from was not enough (as it
lead to linker error as only the only path to
//ios/chrome/browser:downstream_provider_factory for downstream unit tests goes
through //ios/chrome/browser/ui/webui:webui_internal, thus causing link error
when removing this provider).

[sdefresne, 2017-01-05 12:21:21]

Patchset #4 (id:60001) has been deleted

[sdefresne, 2017-01-05 12:21:27]

Patchset #3 (id:40001) has been deleted

[sdefresne, 2017-01-05 12:21:35]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 12:21:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-01-05 12:31:32]

Patchset #3 (id:80001) has been deleted

[sdefresne, 2017-01-05 12:31:39]

Patchset #3 (id:100001) has been deleted

[sdefresne, 2017-01-05 12:32:07]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 12:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 13:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 13:31:43]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-05 18:31:44]

lgtm

https://codereview.chromium.org/2609363003/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm
(right):

https://codereview.chromium.org/2609363003/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm:11: #include
"ios/chrome/browser/favicon/favicon_client_impl.h"
What is this needed for?

[sdefresne, 2017-01-05 20:23:53]

Thank you for the review.

https://codereview.chromium.org/2609363003/diff/120001/ios/chrome/browser/ui/...
File ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm
(right):

https://codereview.chromium.org/2609363003/diff/120001/ios/chrome/browser/ui/...
ios/chrome/browser/ui/webui/chrome_web_ui_ios_controller_factory.mm:11: #include
"ios/chrome/browser/favicon/favicon_client_impl.h"
On 2017/01/05 18:31:44, rohitrao wrote:
> What is this needed for?

Leftover of a never uploaded version of the patch where FaviconClientImpl
allowed registration of a callback to do the mapping URL -> resource ID. Will
remove before landing this CL.

[sdefresne, 2017-01-06 10:13:28]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-01-06 10:13:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2609363003/#ps140001
(title: "Remove incorrect include and obsolete deps.")

[commit-bot: I haz the power, 2017-01-06 10:13:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 11:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 11:31:17]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sdefresne, 2017-01-06 13:12:19]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-06 13:12:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 15:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 15:10:36]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sdefresne, 2017-01-06 15:11:42]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-06 15:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:00:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 17:00:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sdefresne, 2017-01-09 07:45:48]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-01-09 07:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 08:32:19]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1483947948373320,
"parent_rev": "944e00928bdee6bd6961c095cca361586f4a3478", "commit_rev":
"a7f6a8a960a2078be95065df1c713f0c16887763"}

[commit-bot: I haz the power, 2017-01-09 08:32:48]

Description was changed from

==========
Remove ChromeBrowserProvider::GetFaviconForURL().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes.

Move the implementation of GetFaviconForNativeApplicationURL() from
ChromeWebUIIOSControllerFactory to FaviconClientImpl to untangle a
complex and deep circular dependencies causing linker failures when
removing DownstreamChromiumBrowserProvider.

BUG=676278
==========

to

==========
Remove ChromeBrowserProvider::GetFaviconForURL().

The method can now be inlined at the call site as the implementation
has been upstreamed. Removing the method and obsolete includes.

Move the implementation of GetFaviconForNativeApplicationURL() from
ChromeWebUIIOSControllerFactory to FaviconClientImpl to untangle a
complex and deep circular dependencies causing linker failures when
removing DownstreamChromiumBrowserProvider.

BUG=676278

Review-Url: https://codereview.chromium.org/2609363003
Cr-Commit-Position: refs/heads/master@{#442208}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7f6a8a960a2078be95065df1c71...
==========

[commit-bot: I haz the power, 2017-01-09 08:32:50]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/a7f6a8a960a2078be95065df1c71...