Refactor DrawTextureQuad and CheckPixels in gl_tests util

Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5fae2b9711128d4c0b88064c6cda1dfe97119e4e
Cr-Commit-Position: refs/heads/master@{#441310}

[qiankun, 2016-12-23 14:30:47]

Description was changed from

==========
Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
==========

to

==========
Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2016-12-23 16:41:54]

Patchset #1 (id:1) has been deleted

[qiankun, 2016-12-23 16:42:03]

Patchset #1 (id:20001) has been deleted

[qiankun, 2016-12-23 16:42:23]

Patchset #1 (id:40001) has been deleted

[qiankun, 2016-12-23 16:53:43]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2016-12-23 16:53:44]

After this refactoring, it will be easy to add new tests for other enhancements.
PTAL.

[Zhenyao Mo, 2017-01-03 23:09:00]

lgtm

https://codereview.chromium.org/2602563002/diff/80001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_test_utils.h (right):

https://codereview.chromium.org/2602563002/diff/80001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_test_utils.h:64: const uint8_t* mask);
Can you add a comment what "mask" means?

Say, "if mark is nullptr, compare all color channels; otherwise, compare the
channels whose corresponding mask bit is true"

[qiankun, 2017-01-04 02:39:57]

Thanks. Land now.

https://codereview.chromium.org/2602563002/diff/80001/gpu/command_buffer/test...
File gpu/command_buffer/tests/gl_test_utils.h (right):

https://codereview.chromium.org/2602563002/diff/80001/gpu/command_buffer/test...
gpu/command_buffer/tests/gl_test_utils.h:64: const uint8_t* mask);
On 2017/01/03 23:09:00, Zhenyao Mo wrote:
> Can you add a comment what "mask" means?
> 
> Say, "if mark is nullptr, compare all color channels; otherwise, compare the
> channels whose corresponding mask bit is true"

Done.

[qiankun, 2017-01-04 02:52:55]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2017-01-04 02:52:56]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2602563002/#ps120001
(title: "rebase only")

[commit-bot: I haz the power, 2017-01-04 02:53:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 03:33:04]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483498375748130,
"parent_rev": "c6dd81ec85b2fb0bfaa3769926f38094f24b7fa0", "commit_rev":
"2c9860bf5734461735a1ac69165aae9ab726ab3a"}

[commit-bot: I haz the power, 2017-01-04 03:33:28]

Description was changed from

==========
Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2602563002
==========

[commit-bot: I haz the power, 2017-01-04 03:33:29]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2017-01-04 03:35:39]

Description was changed from

==========
Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2602563002
==========

to

==========
Refactor DrawTextureQuad and CheckPixels in gl_tests util

BUG=612542
TEST=gl_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5fae2b9711128d4c0b88064c6cda1dfe97119e4e
Cr-Commit-Position: refs/heads/master@{#441310}
==========

[commit-bot: I haz the power, 2017-01-04 03:35:40]

Patchset 4 (id:??) landed as
https://crrev.com/5fae2b9711128d4c0b88064c6cda1dfe97119e4e
Cr-Commit-Position: refs/heads/master@{#441310}