gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc - Issue 2602563002: Refactor DrawTextureQuad and CheckPixels in gl_tests util

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc

Issue 2602563002: Refactor DrawTextureQuad and CheckPixels in gl_tests util (Closed)

Patch Set: rebase only Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc ('k') | gpu/command_buffer/tests/gl_lose_context_chromium_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc

diff --git a/gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc b/gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc

index ea052f0ae94b817b6ca1aecdb20fffcfa53a11e5..ab176e97111ef0508118b8b7f99ad36c8cc335c7 100644

--- a/gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc

+++ b/gpu/command_buffer/tests/gl_iosurface_readback_workaround_unittest.cc

@@ -67,14 +67,14 @@ TEST_F(GLIOSurfaceReadbackWorkaroundTest, ReadPixels) {

glClearColor(33.0 / 255.0, 44.0 / 255.0, 55.0 / 255.0, 66.0 / 255.0);

glClear(GL_COLOR_BUFFER_BIT);

const uint8_t expected[4] = {33, 44, 55, 66};

- EXPECT_TRUE(

- GLTestHelper::CheckPixels(0, 0, 1, 1, 1 /* tolerance */, expected));

+ EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 1 /* tolerance */, expected,

+ nullptr));

glClearColor(14.0 / 255.0, 15.0 / 255.0, 16.0 / 255.0, 17.0 / 255.0);

glClear(GL_COLOR_BUFFER_BIT);

const uint8_t expected2[4] = {14, 15, 16, 17};

- EXPECT_TRUE(

- GLTestHelper::CheckPixels(0, 0, 1, 1, 1 /* tolerance */, expected2));

+ EXPECT_TRUE(GLTestHelper::CheckPixels(0, 0, 1, 1, 1 /* tolerance */,

+ expected2, nullptr));

glReleaseTexImage2DCHROMIUM(source_target, image_id);

glDestroyImageCHROMIUM(image_id);