Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method (Closed)

Created:
3 years, 12 months ago by Camillo Bruni
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
devtools-reviews_chromium.org, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add Object::IsNullOrUndefined(Isolate*) helper method The pattern IsNull(isolate) || IsUndefined(isolate) is used in many places all over the code base. Review-Url: https://codereview.chromium.org/2601503002 Cr-Commit-Position: refs/heads/master@{#42138} Committed: https://chromium.googlesource.com/v8/v8/+/09167bf6cd4aaa321803eb8f4261295840e89730

Patch Set 1 #

Patch Set 2 : fixing merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -80 lines) Patch
M include/v8.h View 1 3 chunks +27 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M src/builtins/builtins-array.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-utils.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/inspector/string-util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/messages.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Camillo Bruni
PTAL
3 years, 12 months ago (2016-12-22 14:17:29 UTC) #4
Yang
lgtm
3 years, 12 months ago (2016-12-22 14:27:21 UTC) #5
Benedikt Meurer
LGTM.
3 years, 11 months ago (2017-01-09 10:52:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601503002/1
3 years, 11 months ago (2017-01-09 11:32:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/14498) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
3 years, 11 months ago (2017-01-09 11:34:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601503002/20001
3 years, 11 months ago (2017-01-09 12:07:18 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 13:40:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/09167bf6cd4aaa321803eb8f4261295840e...

Powered by Google App Engine
This is Rietveld 408576698