src/debug/debug.cc - Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug.cc

Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method (Closed)

Patch Set: fixing merge conflicts Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug.cc

diff --git a/src/debug/debug.cc b/src/debug/debug.cc

index 1bd69cbc882ddf5faf10280abc9d1bd0a59b3602..8b411b688696d37132b7d4caf4774d6461c987b6 100644

--- a/src/debug/debug.cc

+++ b/src/debug/debug.cc

@@ -2045,7 +2045,7 @@ void Debug::SetEventListener(Handle<Object> callback,

event_listener_data_ = Handle<Object>();

// Set new entry.

- if (!callback->IsUndefined(isolate_) && !callback->IsNull(isolate_)) {

+ if (!callback->IsNullOrUndefined(isolate_)) {

event_listener_ = global_handles->Create(*callback);

if (data.is_null()) data = isolate_->factory()->undefined_value();

event_listener_data_ = global_handles->Create(*data);

« no previous file with comments | « src/compiler/js-call-reducer.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »