src/full-codegen/x87/full-codegen-x87.cc - Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x87/full-codegen-x87.cc

Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method (Closed)

Patch Set: fixing merge conflicts Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x87/full-codegen-x87.cc

diff --git a/src/full-codegen/x87/full-codegen-x87.cc b/src/full-codegen/x87/full-codegen-x87.cc

index fd725c95cf95cc984af4ef59874167fcab428966..3288f54e81a629892266e9685fdc4272c4783f18 100644

--- a/src/full-codegen/x87/full-codegen-x87.cc

+++ b/src/full-codegen/x87/full-codegen-x87.cc

@@ -477,10 +477,8 @@ void FullCodeGenerator::TestContext::Plug(Handle<Object> lit) const {

true,

true_label_,

false_label_);

- DCHECK(lit->IsNull(isolate()) || lit->IsUndefined(isolate()) ||

- !lit->IsUndetectable());

- if (lit->IsUndefined(isolate()) || lit->IsNull(isolate()) ||

- lit->IsFalse(isolate())) {

+ DCHECK(lit->IsNullOrUndefined(isolate()) || !lit->IsUndetectable());

+ if (lit->IsNullOrUndefined(isolate()) || lit->IsFalse(isolate())) {

if (false_label_ != fall_through_) __ jmp(false_label_);

} else if (lit->IsTrue(isolate()) || lit->IsJSObject()) {

if (true_label_ != fall_through_) __ jmp(true_label_);

« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »