src/builtins/builtins-utils.h - Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-utils.h

Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method (Closed)

Patch Set: fixing merge conflicts Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-utils.h

diff --git a/src/builtins/builtins-utils.h b/src/builtins/builtins-utils.h

index 3a458a0f710bf522dfc4565ff4a6af0d23e9fd7b..be689ac03866d784ce4eaae0572578e87034fb75 100644

--- a/src/builtins/builtins-utils.h

+++ b/src/builtins/builtins-utils.h

@@ -145,8 +145,7 @@ class BuiltinArguments : public Arguments {

// or converts the receiver to a String otherwise and assigns it to a new var

// with the given {name}.

#define TO_THIS_STRING(name, method) \

- if (args.receiver()->IsNull(isolate) || \

- args.receiver()->IsUndefined(isolate)) { \

+ if (args.receiver()->IsNullOrUndefined(isolate)) { \

THROW_NEW_ERROR_RETURN_FAILURE( \

isolate, \

NewTypeError(MessageTemplate::kCalledOnNullOrUndefined, \

« no previous file with comments | « src/builtins/builtins-object.cc ('k') | src/compiler/js-call-reducer.cc » ('j') | no next file with comments »